Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: specify your own docker base-image #1

Closed
chiefy opened this issue Apr 13, 2016 · 1 comment
Closed

Feature request: specify your own docker base-image #1

chiefy opened this issue Apr 13, 2016 · 1 comment

Comments

@chiefy
Copy link

chiefy commented Apr 13, 2016

I love Alpine, but if anything in node_modules needs rebuilt, you will have to figure out what apk to add. Would be awesome to be able to specify your own base image (and repo) pull in package.json:

...
"autochecker": {
  "repo-host": "https://quay.io",
  "base-image": "someuser/nodejs"
}
...

awesome project btw!

@victorb
Copy link
Owner

victorb commented Apr 13, 2016

As I see it, PR #2 would fix this, because you could provide your own Dockerfile :)

Maybe this way would be easier and simpler, but providing a Dockerfile I think is simple enough.

Thanks for the idea 👍

@victorb victorb closed this as completed Apr 13, 2016
victorb pushed a commit that referenced this issue May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants