Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): added support for custom Docker file template #2

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

bahmutov
Copy link
Collaborator

I needed extra tools to test my project bahmutov/really-need#31 and added loading DockerTemplate file if available.

@victorb
Copy link
Owner

victorb commented Apr 13, 2016

Thanks, I like this PR and feature! However, I just redid some of the UI of the tool and moved around some Dockerfile stuff, so might take a while to merge but I'll get there :)

Thanks a lot!

@bahmutov
Copy link
Collaborator Author

Sure!

Sent from my iPhone

On Apr 13, 2016, at 12:52, ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ notifications@github.com wrote:

Thanks, I like this PR and feature! However, I just redid some of the UI of the tool and moved around some Dockerfile stuff, so might take a while to merge but I'll get there :)

Thanks a lot!


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@victorb victorb merged commit 63059b5 into victorb:master Apr 13, 2016
@victorb
Copy link
Owner

victorb commented Apr 13, 2016

Merged! Wasn't as conflicty as I thought, thanks a lot for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants