Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable decouple-vsphere-csi-driver by default #411

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Enable decouple-vsphere-csi-driver by default #411

merged 1 commit into from
Nov 9, 2021

Conversation

deepakkinni
Copy link
Collaborator

@deepakkinni deepakkinni commented Nov 8, 2021 •
edited by xing-yang
Loading

What this PR does / why we need it:
Enabling the feature flag by default.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Testing

Running tests: ./pkg/...
go test ./pkg/... -timeout=300s
go: downloading github.com/stretchr/testify v1.7.0
go: downloading k8s.io/kube-openapi v0.0.0-20210421082810-95288971da7e
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/apis/backupdriver/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/apis/datamover/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backuprepository	0.222s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/builder	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/buildinfo	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd	0.181s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver/cli/install	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver/cli/server	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr/cli/install	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr/cli/server	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/common/vsphere	0.039s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/constants	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/controller	0.207s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/dataMover	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/fake	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/scheme	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/backupdriver/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/backupdriver/v1alpha1/fake	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/datamover/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/datamover/v1alpha1/fake	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/crds	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/backupdriver	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/backupdriver/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/datamover	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/datamover/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/listers/backupdriver/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/listers/datamover/v1alpha1	[no test files]
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/install	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/ivd	0.126s
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/paravirt	0.205s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/plugin	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/plugin/util	0.072s
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotUtils	0.091s
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotmgr	0.071s
?   	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/test	[no test files]
ok  	github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/utils	0.085s
Success!

Does this PR introduce a user-facing change?:

Enables decouple-vsphere-csi-driver by default.

Signed-off-by: Deepak Kinni dkinni@vmware.com

Enable decouple-vsphere-csi-driver by default
88503ea 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/642/

xing-yang
xing-yang approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lintongj
lintongj approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@lintongj lintongj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please make sure regression get passed before merging it.

@deepakkinni deepakkinni merged commit fb16664 into vmware-tanzu:main Nov 9, 2021
deepakkinni pushed a commit to deepakkinni/velero-plugin-for-vsphere that referenced this pull request Nov 9, 2021
Enable decouple-vsphere-csi-driver by default (vmware-tanzu#411)
dad8f5a 
Enabling the feature flag by default.

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@lintongj lintongj mentioned this pull request Nov 9, 2021
Merged
deepakkinni pushed a commit that referenced this pull request Nov 9, 2021
Enable decouple-vsphere-csi-driver by default (#411) (#412)
bee4deb 
Enabling the feature flag by default.

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@deepakkinni deepakkinni deleted the enable_decoup_v1 branch May 3, 2023 01:41
lipingxue pushed a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request May 19, 2023
@lipingxue
Enable decouple-vsphere-csi-driver by default (vmware-tanzu#411)
5a22936 
Enabling the feature flag by default.

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang approved these changes

@lintongj lintongj lintongj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepakkinni @svcbot-qecnsdp @xing-yang @lintongj