Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crossport]Enable decouple-vsphere-csi-driver by default (#411) #412

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

deepakkinni
Copy link
Collaborator

@deepakkinni deepakkinni commented Nov 9, 2021

What this PR does / why we need it:
Crossport #411. Enabling the feature flag by default.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable decouple-vsphere-csi-driver as default.

Signed-off-by: Deepak Kinni dkinni@vmware.com

Enabling the feature flag by default.

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@lintongj
Copy link
Contributor

lintongj commented Nov 9, 2021

@deepakkinni would you please change the release-note message a bit? Just something like Enable decouple-vsphere-csi-driver as default.

@deepakkinni
Copy link
Collaborator Author

@deepakkinni would you please change the release-note message a bit? Just something like Enable decouple-vsphere-csi-driver as default.

done.

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepakkinni deepakkinni merged commit bee4deb into vmware-tanzu:release-1.3 Nov 9, 2021
@svcbot-qecnsdp
Copy link

Sorry, some of the pre-check tests are failing for this PR !

Please check the Jenkins job for more details
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/643/

@deepakkinni deepakkinni deleted the xport_fenab_v2 branch May 3, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants