feat/unit-testing #169
Merged
feat/unit-testing #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying head-start with
|
| Latest commit: |
dcc4a2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84ec8210.head-start.pages.dev |
| Branch Preview URL: | https://feat-unit-testing.head-start.pages.dev |
jbmoelker
reviewed
Sep 9, 2024
jbmoelker
reviewed
Sep 9, 2024
jbmoelker
reviewed
Sep 9, 2024
jbmoelker
reviewed
Sep 9, 2024
jbmoelker
approved these changes
Sep 16, 2024
luukbrauckmann
pushed a commit
that referenced
this pull request
Sep 20, 2024
<!-- example: - Fixes wrong color in button - Adds a new page --> - adds `test` and `unit-test` scripts - adds unit tests for `i18n` lib function - adds a `vitest.config.ts` so we can configure the testing suite - adds new deps needed for testing - adds `unit-tests` step to github action CI so we test each commit to the repo from now on - uses the `github actions reporter` to enable formatting and highlighting of testing output in the CI pipeline - adds documentation for testing setup - fixes the following issues in the i18n lib function: - interpolation did not work in the `t` function - params and language props were not supported in `t` function Part of #103 - verify that the tests in the CI were succesful - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - [x] I have made updated relevant documentation files (in project README, docs/, etc) - [x] I have added a decision log entry if the change affects the architecture or changes a significant technology - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
testandunit-testscriptsi18nlib functionvitest.config.tsso we can configure the testing suiteunit-testsstep to github action CI so we test each commit to the repo from now ongithub actions reporterto enable formatting and highlighting of testing output in the CI pipelinetfunctiontfunctionAssociated issue
Part of #103
How to test
Checklist