chore: component testing #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying head-start with
|
| Latest commit: |
24f5842
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ba9f26e.head-start.pages.dev |
| Branch Preview URL: | https://feat-component-testing.head-start.pages.dev |
luukbrauckmann
commented
Sep 17, 2024
luukbrauckmann
commented
Sep 17, 2024
jurgenbelien
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Good job, I can imagine this took quite some effort!
I do have some remarks regarding how to structure tests and how to handle the data going into the tests. I also noticed some changes in the component to sidestep some issues with the renderer. I think it might be wise to skip those components instead of adding behavior that might have unintended consequences.
And a final tip that I did not mention in the comments: take a look at your commit history and see if you can clean that up a bit. You have three subsequent commits called 'Refactor'. Are you refactoring things you did in this branch earlier? If so, try to squash those with the changes your made earlier, they are no longer relevant. If not, try to elaborate a bit on what you are refactoring and why. Make commits atomic and only about the issue at hand.
luukbrauckmann
force-pushed
the
feat/component-testing
branch
from
7ba8552
to
10edeef
Compare
# Changes - Adds sitelinks search box structured data # Associated issue Resolves #109 # How to test 1. Copy preview link 2. Go to https://search.google.com/test/rich-results 3. Paste preview link in field # Checklist - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - [x] I have made updated relevant documentation files (in project README, docs/, etc) - [x] I have added a decision log entry if the change affects the architecture or changes a significant technology - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) --> --------- Co-authored-by: Jasper Moelker <jasper@voorhoede.nl>
# Changes - Trims trailing whitespace from anchor (text) content. This prevents an underline from extending beyond the word boundary. # How to test 1. Open preview link 2. Scroll to the hyperlinks example. 3. See that their link does not extend to the space after the last word. 4. Compare that with the current https://head-start.pages.dev/en/ # Checklist - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - ~~I have made updated relevant documentation files (in project README, docs/, etc)~~ - ~~I have added a decision log entry if the change affects the architecture or changes a significant technology~~ - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) --> --------- Co-authored-by: Jasper Moelker <jasper@voorhoede.nl>
# Changes - Adds TS plugin for .astro files, so it won't be highlighted as an error. # Associated issue Resolves #175 # How to test <!-- example: 1. Open a non VSCode editor (best is to test in Zed) 2. Checkout branch 3. Run `npm ci` 4. Open a .ts file which imports an .astro file. For example src/components/Tabs/index.ts 5. Imports should not be highlighted as error. --> # Checklist - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - [x] I have made updated relevant documentation files (in project README, docs/, etc) - [x] I have added a decision log entry if the change affects the architecture or changes a significant technology - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) --> Co-authored-by: Jasper Moelker <jasper@voorhoede.nl>
<!-- example: - Fixes wrong color in button - Adds a new page --> - adds `test` and `unit-test` scripts - adds unit tests for `i18n` lib function - adds a `vitest.config.ts` so we can configure the testing suite - adds new deps needed for testing - adds `unit-tests` step to github action CI so we test each commit to the repo from now on - uses the `github actions reporter` to enable formatting and highlighting of testing output in the CI pipeline - adds documentation for testing setup - fixes the following issues in the i18n lib function: - interpolation did not work in the `t` function - params and language props were not supported in `t` function Part of #103 - verify that the tests in the CI were succesful - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - [x] I have made updated relevant documentation files (in project README, docs/, etc) - [x] I have added a decision log entry if the change affects the architecture or changes a significant technology - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) -->
luukbrauckmann
force-pushed
the
feat/component-testing
branch
from
10edeef
to
f9c6d2f
Compare
luukbrauckmann
commented
Sep 24, 2024
luukbrauckmann
commented
Sep 24, 2024
luukbrauckmann
commented
Sep 24, 2024
luukbrauckmann
force-pushed
the
feat/component-testing
branch
2 times, most recently
from
4f04c04
to
8b3d04e
Compare
jurgenbelien
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Associated issue
None
How to test
npm cinpm run testChecklist