Unit test harness for OARO models #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohezhiming
requested review from
adam-a-a,
agarciadiego,
MarcusHolly and
ElmiraShamlou
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
+ Coverage 93.83% 93.85% +0.01%
==========================================
Files 338 338
Lines 35354 35354
==========================================
+ Hits 33174 33181 +7
+ Misses 2180 2173 -7 ☔ View full report in Codecov by Sentry. |
MarcusHolly
reviewed
Apr 25, 2024
Comment on lines
62
to
63
| self.default_absolute_tolerance = 1e-12 | ||
| self.default_relative_tolerance = 1e-6 | ||
| self.default_absolute_tolerance = 1e-5 | ||
| self.default_relative_tolerance = 1e-3 |
There was a problem hiding this comment.
Just want to double check that these are reasonable tolerance values
There was a problem hiding this comment.
I use the same tolerance as previous set in the testing file. And this is already the smallest tolerance for passing the tests.
ElmiraShamlou
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: