modifies MD0D test to use unit test harness #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
- Coverage 93.83% 93.82% -0.01%
==========================================
Files 338 338
Lines 35354 35354
==========================================
- Hits 33174 33172 -2
- Misses 2180 2182 +2 ☔ View full report in Codecov by Sentry. |
MarcusHolly
reviewed
Apr 25, 2024
Comment on lines
-62
to
+63
| self.default_absolute_tolerance = 1e-12 | ||
| self.default_relative_tolerance = 1e-6 | ||
| self.default_absolute_tolerance = 1e-5 | ||
| self.default_relative_tolerance = 1e-3 |
There was a problem hiding this comment.
Same comment as #1367 (comment). Are these tolerances reasonable? If so, I think this and #1367 are good-to-go. If not, then we would need to address why some of the solutions fail at lower tolerances.
luohezhiming
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: