Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc for electrodialysis flowsheet #1385

Merged
merged 21 commits into from
May 23, 2024
Merged

Doc for electrodialysis flowsheet #1385

merged 21 commits into from
May 23, 2024

Conversation

lbibl
Copy link
Contributor

@lbibl lbibl commented May 11, 2024

Fixes/Resolves:

To check a half box in #1219

Summary/Motivation:

Doc for watertap/examples/flowsheets/electrodialysis/electrodialysis_1stack_conc_recirc.py

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbibl lbibl self-assigned this May 11, 2024
@lbibl lbibl marked this pull request as ready for review May 11, 2024 16:24
@codecov Codecov
Copy link

codecov bot commented May 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.02%. Comparing base (163a7d2) to head (80b47ec).
Report is 57 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files         335      335           
  Lines       35620    35620           
=======================================
  Hits        33491    33491           
  Misses       2129     2129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced May 13, 2024
Closed
Merged
MarcusHolly
MarcusHolly requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider shortening the title and carrying over the feedback from #1386

docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
@hunterbarber hunterbarber self-requested a review May 14, 2024 18:39
@lbibl lbibl requested a review from MarcusHolly May 16, 2024 14:54
MarcusHolly
MarcusHolly requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
lbibl and others added 5 commits May 16, 2024 08:25
@lbibl
add lcow exp
9d2cd23
@lbibl @MarcusHolly
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
3be383e 
…c_recirc.rst

Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
@lbibl @MarcusHolly
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
933c719 
…c_recirc.rst

Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
@lbibl @MarcusHolly
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
565d221 
…c_recirc.rst

Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
@lbibl
reorder
5e3752c
@lbibl lbibl requested a review from MarcusHolly May 16, 2024 18:25
MarcusHolly
MarcusHolly approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added 1.0 Hard requirement for the 1.0 release Priority:Normal Normal Priority Issue or PR labels May 16, 2024
hunterbarber
hunterbarber requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@hunterbarber hunterbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here

docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst
"Pump efficiency", ":math:`0.8`", ":math:`1`", "--"


References
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is going on with these in the build that I'm not sure of
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are proper printout by the used referencing codes. The numbers in "()" tell the subindices of places where that citation item is relevant.

docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
docs/technical_reference/flowsheets/electrodialysis_1stack_conc_recirc.rst Outdated Show resolved Hide resolved
lbibl and others added 4 commits May 23, 2024 06:23
@lbibl @hunterbarber
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
a7b5169 
…c_recirc.rst

Co-authored-by: Hunter Barber <101219154+hunterbarber@users.noreply.github.com>
@lbibl @hunterbarber
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
df898ca 
…c_recirc.rst

Co-authored-by: Hunter Barber <101219154+hunterbarber@users.noreply.github.com>
@lbibl @hunterbarber
Update docs/technical_reference/flowsheets/electrodialysis_1stack_con…
8c83858 
…c_recirc.rst

Co-authored-by: Hunter Barber <101219154+hunterbarber@users.noreply.github.com>
@lbibl
Merge branch 'main' into edfsdoc
80b47ec
@bknueven bknueven merged commit e44c9fe into watertap-org:main May 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusHolly MarcusHolly MarcusHolly approved these changes

@hunterbarber hunterbarber hunterbarber approved these changes

Assignees

@lbibl lbibl

Labels
1.0 Hard requirement for the 1.0 release Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbibl @MarcusHolly @hunterbarber @ksbeattie @bknueven