Doc for second electrodialysis flowsheet #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 339 339
Lines 35931 35931
=======================================
Hits 33723 33723
Misses 2208 2208 ☔ View full report in Codecov by Sentry. |
21 tasks
MarcusHolly
requested changes
May 14, 2024
There was a problem hiding this comment.
A couple of minor things to address. Most of these comments also apply to #1385
Comment on lines
+25
to
+28
| Documentation for unit models from IDAES: | ||
| * `Feed block <https://idaes-pse.readthedocs.io/en/latest/reference_guides/model_libraries/generic/unit_models/feed.html>`_ | ||
| * `Separator <https://idaes-pse.readthedocs.io/en/latest/reference_guides/model_libraries/generic/unit_models/separator.html>`_ | ||
| * `Product block <https://idaes-pse.readthedocs.io/en/latest/reference_guides/model_libraries/generic/unit_models/product.html>`_ |
There was a problem hiding this comment.
In other flowsheet documentation, we have not listed these IDAES models. Personally I think they can be left out since these will be present in almost every flowsheet, but I'm curious what others think.
MarcusHolly
requested review from
adam-a-a,
agarciadiego,
luohezhiming and
ElmiraShamlou
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
MarcusHolly
approved these changes
May 14, 2024
agarciadiego
approved these changes
May 14, 2024
Co-authored-by: agarciadiego <40575271+agarciadiego@users.noreply.github.com>
MarcusHolly
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
check ED * @lbibl in #1219
Summary/Motivation:
As title
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: