feat: respect my_clients_only param in sendh callback #14587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
approved these changes
Jan 30, 2023
atomrc
reviewed
Jan 30, 2023
atomrc
reviewed
Jan 30, 2023
PatrykBuniX
force-pushed
the
feat/mls-conf-my-clients-only
branch
from
da69a85
to
ca76553
Compare
atomrc
approved these changes
Jan 31, 2023
PatrykBuniX
added a commit
that referenced
this pull request
Feb 14, 2023
* feat: Initiate mls conference call * upgrade core * upgrade core * fix tests * runfix: fix tests * fix tests * upgrade avs * ugprade avs * upgrade avs * feat: answer mls conference call [FS-1285] (#14446) * feat: answer incoming mls conference call * runfix: dont pass qualified convid to json * refactor: joinOngoingCall method * fix joining call * upgrade core * oups * fix calling flow (join conversation after the call is created) * chore: upgrade core * runfix: refactor, fix userids * upgrade @wireapp/core * refactor: Handle automatic epoch updates * fix epoch * feat: unsubscribe from mls service events after call ends (#14552) * feat: add ability to unsubscribe from mls service events * feat: onRequestClientsCallback * feat: use map for calling subs * chore: update comment Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * runfix: make sure we always get fresh subconv from api * feat: react to KeyGenerator timer req_new_epoch handler * chore: type for epoch info member * refactor: exclude mls-related conference logic to separate module (#14584) * refactor: exclude mls-related conference logic to separate module * chore: make generate members method private * runfix: do not fetch subconvo when group id does not match --------- Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * chore: bump core * test: fix tests * runfix: check if conversation is established before updating epoch info * feat: respect my_clients_only param in sendh callback (#14587) * feat: respect my_clients_only param in sendh callback * chore: update comment * chore: update comment * refactor: add condition to existing if * refactor: pass myClientsOnly as extra prop in sendCallingMessage * refactor: add mls service getter (#14597) * feat: remove stale participants * refactor: use util for qualified id * chore: bump core * feat: check if client is subconversation member before removing it * test: fix tests * runfix: include conversation in in timer key * refactor: create separate function for remove stale client task * chore: bump core * chore: fix types * runfix: get self client id form core * runfix: dont make api call to get subconversation id * chore: improve naming * chore: add comment * refactor: move self client check to top --------- Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
PatrykBuniX
added a commit
that referenced
this pull request
Feb 22, 2023
* feat: Initiate mls conference call * upgrade core * upgrade core * fix tests * runfix: fix tests * fix tests * upgrade avs * ugprade avs * upgrade avs * feat: answer mls conference call [FS-1285] (#14446) * feat: answer incoming mls conference call * runfix: dont pass qualified convid to json * refactor: joinOngoingCall method * fix joining call * upgrade core * oups * fix calling flow (join conversation after the call is created) * chore: upgrade core * runfix: refactor, fix userids * upgrade @wireapp/core * refactor: Handle automatic epoch updates * fix epoch * feat: unsubscribe from mls service events after call ends (#14552) * feat: add ability to unsubscribe from mls service events * feat: onRequestClientsCallback * feat: use map for calling subs * chore: update comment Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * runfix: make sure we always get fresh subconv from api * feat: react to KeyGenerator timer req_new_epoch handler * chore: type for epoch info member * refactor: exclude mls-related conference logic to separate module (#14584) * refactor: exclude mls-related conference logic to separate module * chore: make generate members method private * runfix: do not fetch subconvo when group id does not match --------- Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * chore: bump core * test: fix tests * runfix: check if conversation is established before updating epoch info * feat: respect my_clients_only param in sendh callback (#14587) * feat: respect my_clients_only param in sendh callback * chore: update comment * chore: update comment * refactor: add condition to existing if * refactor: pass myClientsOnly as extra prop in sendCallingMessage * refactor: add mls service getter (#14597) * feat: delete selfuser from conversation on call leave * refactor: move wipeConversation to core * refactor: use getter in leave call func * feat: leave subconversation whenever call ends * chore: bump core and avs versions * test: test that we dont react to newEpoch event once we leave a call * chore: add comment --------- Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.