-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove stale participants #14599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: answer incoming mls conference call * runfix: dont pass qualified convid to json * refactor: joinOngoingCall method * fix joining call * upgrade core * oups * fix calling flow (join conversation after the call is created) * chore: upgrade core * runfix: refactor, fix userids * upgrade @wireapp/core * refactor: Handle automatic epoch updates * fix epoch * feat: unsubscribe from mls service events after call ends (#14552) * feat: add ability to unsubscribe from mls service events * feat: onRequestClientsCallback * feat: use map for calling subs * chore: update comment Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * runfix: make sure we always get fresh subconv from api * feat: react to KeyGenerator timer req_new_epoch handler * chore: type for epoch info member * refactor: exclude mls-related conference logic to separate module (#14584) * refactor: exclude mls-related conference logic to separate module * chore: make generate members method private * runfix: do not fetch subconvo when group id does not match --------- Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
* feat: respect my_clients_only param in sendh callback * chore: update comment * chore: update comment * refactor: add condition to existing if * refactor: pass myClientsOnly as extra prop in sendCallingMessage
Codecov Report
@@ Coverage Diff @@
## dev #14599 +/- ##
==========================================
- Coverage 42.89% 42.84% -0.06%
==========================================
Files 618 618
Lines 21077 21112 +35
Branches 4823 4829 +6
==========================================
+ Hits 9041 9045 +4
- Misses 10902 10933 +31
Partials 1134 1134 |
przemvs
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
atomrc
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems solid 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove stale participants when their audio won't establish during 3 mins timeout.
See https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/698908878/Use+case+remove+stale+participants+MLS