Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove stale participants #14599

Merged
merged 37 commits into from
Feb 14, 2023
Merged

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Feb 1, 2023

Remove stale participants when their audio won't establish during 3 mins timeout.

See https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/698908878/Use+case+remove+stale+participants+MLS

atomrc and others added 21 commits January 4, 2023 15:55
* feat: answer incoming mls conference call

* runfix: dont pass qualified convid to json

* refactor: joinOngoingCall method

* fix joining call

* upgrade core

* oups

* fix calling flow (join conversation after the call is created)

* chore: upgrade core

* runfix: refactor, fix userids

* upgrade @wireapp/core

* refactor: Handle automatic epoch updates

* fix epoch

* feat: unsubscribe from mls service events after call ends (#14552)

* feat: add ability to unsubscribe from mls service events

* feat: onRequestClientsCallback

* feat: use map for calling subs

* chore: update comment

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>

* runfix: make sure we always get fresh subconv from api

* feat: react to KeyGenerator timer req_new_epoch handler

* chore: type for epoch info member

* refactor: exclude mls-related conference logic to separate module (#14584)

* refactor: exclude mls-related conference logic to separate module

* chore: make generate members method private

* runfix: do not fetch subconvo when group id does not match

---------

Co-authored-by: Thomas Belin <me@thomasbelin.fr>
Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
* feat: respect my_clients_only param in sendh callback

* chore: update comment

* chore: update comment

* refactor: add condition to existing if

* refactor: pass myClientsOnly as extra prop in sendCallingMessage
Base automatically changed from feat/mls-conferencing to dev February 1, 2023 16:16
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #14599 (4467447) into dev (56a854b) will decrease coverage by 0.06%.
The diff coverage is 10.81%.

@@            Coverage Diff             @@
##              dev   #14599      +/-   ##
==========================================
- Coverage   42.89%   42.84%   -0.06%     
==========================================
  Files         618      618              
  Lines       21077    21112      +35     
  Branches     4823     4829       +6     
==========================================
+ Hits         9041     9045       +4     
- Misses      10902    10933      +31     
  Partials     1134     1134              

@PatrykBuniX PatrykBuniX marked this pull request as ready for review February 14, 2023 12:07
Copy link
Contributor

@przemvs przemvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@atomrc atomrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems solid 😎

@PatrykBuniX PatrykBuniX enabled auto-merge (squash) February 14, 2023 15:52
@PatrykBuniX PatrykBuniX merged commit 4209db2 into dev Feb 14, 2023
@PatrykBuniX PatrykBuniX deleted the feat/remove-stale-participants branch February 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants