-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: Building a site using React components with escaped spaces in path fails #3639
Comments
Good catch @jackmerrill! Noting a few more details here:
|
Another user hit this in Discord: https://discord.com/channels/830184174198718474/845451724738265138/996131165553557625 Bumping up the priority |
We should have a test for a folder with a space in it, using a framework like React! @natemoo-re thinks we might already, but it probably isn't testing the framework part of this bug. |
I investigated this a bit with my limited rollup, vite knowledge and here's where I got: Our compiler's Manually adding a I spent a bit too much time on this, and I fear that the issue might lie in some pieces of code that we don't control / I don't know |
Thanks @Princesseuh!! bumping up the priority again given the recent reports. Also, assigning @bluwy who may have a bit more familiarity with this part of the codebase (cc @matthewp as well!) |
I looked into this today and came with a similar fix at 04e93d1, which fixes the build issue with the repro. #4263 have also added tests, but I also found that other symbols like 🚀 and |
What version of
astro
are you using?1.0.0-beta.47
Are you using an SSR adapter? If so, which one?
Node
What package manager are you using?
yarn
What operating system are you using?
Windows
Describe the Bug
When building an Astro site using the Node SSR adapter, as well with a React component placed in a folder with a space in it's name will fail.
Vite is unable to load the component during build time, thus failing the build.
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-mhnkxf
Participation
The text was updated successfully, but these errors were encountered: