-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests: Special chars in component import paths #4263
Add tests: Special chars in component import paths #4263
Conversation
|
Left a comment on the issue about my exploration of this: #3639 (comment) The fix I committed work, as the tests shows. However, I do believe there might be an underlying issue here somewhere? |
@hippotastic These look great! Are you planning on also fixing or do you just want to submit test cases? If the latter we can get this change in by making the tests with |
@matthewp Great idea! I actually thought this PR would be much more short-lived than it turned out to be. Both Erika and Nate already tried their best to get the underlying issue fixed so we could merge these tests. Do you maybe want to give fixing the issue a shot? It's certainly too advanced for me. :) I'll adapt the test cases as suggested to have CI skip them by tomorrow. |
Yes, I'd love to take a look. Maybe in a separate PR though, would still love to get the tests in first! |
Alright, done! PTAL @matthewp :) |
Thanks so much! |
Changes
.astro
and.mdx
files now:^
)🚀
)()
)[]
)Testing
Docs