-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly escape paths in file names #4584
Conversation
🦋 Changeset detectedLatest commit: 4c0b581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! E2E tests are failing though, any insights?
It took three Astro core members, but we finally got this fixed 💪 Awesome work |
Wow looks like that e2e test alone is quite a rabbithole (again 🥲 ), I can reproduce it locally too. I'll try to look into it tomorrow, marking as draft for now. |
Sorry for building a set of rabbit holes! 😆 But I'm really happy that we're making progress here in getting the tests green! Great work! |
This should be good now. Luckily the CI errors were actually real problems. I toned down some refactors earlier so it should fix specifically the escaping issues. |
Yay, I'm so excited! Finally a working solution to this unexpectedly hard problem. Glad we have a Vite wizard on board now. Thank you so much, @bluwy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only the test author and not a core member, but that LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work!
Changes
Fix #3639
Exotic file names that includes
,
^
,🚀
,(
,{
are now handled and encoded properly.%
is not supported for now as I found Vite had trouble processing it too.Note: Use emojis in file names, the HTML must have
charset="utf-8"
to work.Testing
Enable tests added from #4263
Docs
N/A