Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Update the wordpress/babel-preset to avoid crashes in WP5.8 beta2 #7202

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

samueljseay
Copy link
Contributor

Fixes #7192

Accessibility

n/a

Screenshots

n/a

Detailed test instructions:

Please refer to #7192 for testing instructions. You'll need to use the Wordpress Beta Tester Plugin to update to latest beta2.

No changelog required since this is essentially just a package version bump

@@ -23,7 +23,6 @@ const babelConfigs = {
main: Object.assign( {}, babelDefaultConfig, {
plugins,
presets: [
[ '@babel/preset-typescript' ],
Copy link
Contributor Author

@samueljseay samueljseay Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This preset is shipped with the latest wordpress preset now so duplicating it here causes warnings

@adrianduffell adrianduffell self-requested a review June 17, 2021 01:29
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well in WP 5.7 & 5.8 beta 2

🚀

@ilyasfoo ilyasfoo added this to the 2.4.0 milestone Jun 18, 2021
@ilyasfoo
Copy link
Contributor

ilyasfoo commented Jun 18, 2021

In 785fa9b I've added import regenerator-runtime/runtime to jest setup task in order to replace regenerator in test environment. This is because unit tests were failing with regeneratorRuntime undefined. While there may be a better way to do this (maybe jest or babel config?), we can do it in a follow-up if required. I'm going to merge this PR now to include into RC2.

@ilyasfoo ilyasfoo merged commit 97be157 into main Jun 18, 2021
@ilyasfoo ilyasfoo deleted the dev/update-babel-preset branch June 18, 2021 05:13
ilyasfoo added a commit that referenced this pull request Jun 18, 2021
)

* Update the wordpress/babel-preset to avoid crashes in WP5.8 beta2

* Also update other dependencies dropping IE11 support.

* Update data dep in data package.

* Add back regen runtime.

* Add regenerator-runtime dependency for setting up jest tests

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
ObliviousHarmony pushed a commit to woocommerce/woocommerce that referenced this pull request Mar 18, 2022
…ocommerce/woocommerce-admin#7202)

* Update the wordpress/babel-preset to avoid crashes in WP5.8 beta2

* Also update other dependencies dropping IE11 support.

* Update data dep in data package.

* Add back regen runtime.

* Add regenerator-runtime dependency for setting up jest tests

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On WP 5.8-beta2 WooCommerce > Home and the onboarding wizard fail to load
3 participants