This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Components, Experimental, Data package release prep #7311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatf
approved these changes
Jul 8, 2021
| - Fix WordPress 5.8 compatibility UI fixes #7255 | ||
| - Revert Card component removal #7167. | ||
| - Update DynamicForm, adding initial config memoization. #7256 | ||
| - Update package dependencies |
There was a problem hiding this comment.
Yeah I think just two PRs, same for the data package. Given the PR updates where mostly un-related aside from the dependency updates, I deemed it not necessary. But I could add them in if you think that be helpful?
There was a problem hiding this comment.
It's up to you. I have no strong opinion one way or another; just caught my eye scanning this PR.
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump versions in packages, originally was only going to do
experimental, but given I removed theexperimentaldependency fromcomponentsI decided to do that one as well.Also release the
datapackage, mostly because of a missing package dependency left over from the last release.I added several changelogs that I noticed where in history, please check if those look ok. I decided to only do a patch for the data package, given the changes where minimal.
No changelog necessary.
Test instructions
Read through the changes, make sure they make sense