Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error view layout and constraints on iPad for non-WordPress sites and when Jetpack is not installed #13991

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

pmusolino
Copy link
Member

Closes: #13813

Description

This PR updates the layout and constraints for the ULErrorViewController to improve the alignment and appearance of error views, for iPad devices. The changes address misaligned views and refine the layout for better visual consistency.

  • Removed some unused stack view constraints.
  • Refactored constraints to improve layout consistency and avoid ambiguity.

Steps to reproduce

Using iPad simulator

Case 1

  1. Log in to an existing testing store with Jetpack.
  2. Navigate to menu.
  3. Tap on the store (first row).
  4. Press “Connect existing store”
  5. Add a store that doesn’t exist (eg. example.com).
  6. Notice that the view telling you that the site is not a WordPress site is not centered.

Case 2

  1. Log in to an existing testing store with Jetpack.
  2. Create a testing jurassic ninja site with Woo installed but without Jetpack.
  3. Navigate to menu.
  4. Tap on the store (first row).
  5. Press “Connect existing store”
  6. Add the jurassic ninja store that you created.
  7. Notice that the view telling you to install Jetpack is not centered.

Testing information

I just tested following the steps to reproduce above, and now the view is centered.

Screenshots

Before After
Simulator Screenshot - iPad mini (6th generation) - 2024-09-17 at 14 44 40 Simulator Screenshot - iPad mini (6th generation) - 2024-09-17 at 17 15 44

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

- Remove `ambiguous` attribute from scrollView
- Add new bottom constraint for stackView
- Adjust height of view with ID "B4M-dS-aoc" from 132.5 to 32
- Move imageView with ID "Osv-Wo-lxW" frame y-coordinate from 148.5 to 48
- Change stackView frame y-coordinate from 370.5 to 270
- Add new view with ID "QgR-Qw-rQN" and set its height constraint relative to "B4M-dS-aoc"
…raint and stackViewTrailingConstraint in ULErrorViewController
@pmusolino pmusolino added type: bug A confirmed bug. feature: login Related to any part of the log in or sign in flow, or authentication. labels Sep 17, 2024
@pmusolino pmusolino added this to the 20.5 milestone Sep 17, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13991-7ba28d4
Version20.4
Bundle IDcom.automattic.alpha.woocommerce
Commit7ba28d4
App Center BuildWooCommerce - Prototype Builds #10907
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The image in error popups is not centered on the iPad
2 participants