Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error view layout and constraints on iPad for non-WordPress sites and when Jetpack is not installed #13991

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+58 −38
Open

Update error view layout and constraints on iPad for non-WordPress sites and when Jetpack is not installed #13991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce9a239
refactor: ULErrorViewController constraints
pmusolino Sep 17, 2024
69d307f
Update ULErrorViewController.xib layout constraints
pmusolino Sep 17, 2024
a3ea8c4
Update ULErrorViewController.xib layout and constraints
pmusolino Sep 17, 2024
2aa28d9
refactor: Remove unused stack view constraints: stackViewLeadingConst…
pmusolino Sep 17, 2024
7ba28d4
update: release notes 20.5
pmusolino Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
-----
- [*] Blaze: Schedule a reminder local notification asking to continue abandoned campaign creation flow. [https://github.com/woocommerce/woocommerce-ios/pull/13950]
- [*] Blaze: Handle tap on local notifications to open campaign creation. [https://github.com/woocommerce/woocommerce-ios/pull/13968]
- [*] Some error views were misaligned on iPad when the store was not a WordPress site or didn't have Jetpack installed. Now, everything is perfectly centered.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the PR link to the release notes.

- [internal] Mobile Payments: Log errors from Stripe Terminal [https://github.com/woocommerce/woocommerce-ios/pull/13976]


Expand Down
5 changes: 0 additions & 5 deletions WooCommerce/Classes/Authentication/Navigation Exceptions/ULErrorViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ final class ULErrorViewController: UIViewController {
/// Used to adjust the button width in unified views provided by WPAuthenticator
@IBOutlet private weak var buttonViewLeadingConstraint: NSLayoutConstraint!
@IBOutlet private weak var buttonViewTrailingConstraint: NSLayoutConstraint!
@IBOutlet private weak var stackViewLeadingConstraint: NSLayoutConstraint!
@IBOutlet private weak var stackViewTrailingConstraint: NSLayoutConstraint!

private var primaryButtonSubscription: AnyCancellable?
private var siteFaviconSubscription: AnyCancellable?
Expand Down Expand Up @@ -245,9 +243,6 @@ private extension ULErrorViewController {

buttonViewLeadingConstraint?.constant = margin
buttonViewTrailingConstraint?.constant = margin

stackViewLeadingConstraint?.constant = margin
stackViewTrailingConstraint?.constant = margin
}

private enum ButtonViewMarginMultipliers {
Expand Down
Loading