Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Gallery v2 Flag over from the editor #15129

Merged
merged 12 commits into from
Sep 2, 2021
Merged

Pass the Gallery v2 Flag over from the editor #15129

merged 12 commits into from
Sep 2, 2021

Conversation

antonis
Copy link

@antonis antonis commented Aug 4, 2021 •
edited
Loading

Related PRs

WordPress-FluxC-Android: wordpress-mobile/WordPress-FluxC-Android#2065
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3793
gutenberg: WordPress/gutenberg#33544

Description

This PR adds the Gallery v2 Flag to the EditorTheme to be passed down to the Editor

To test

See WordPress/gutenberg#33544

Regression Notes

  1. Potential unintended areas of impact
  • This could also affect the changes for Global Style Settings
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Offline Support - steps
  • FSE Colors and Gradients - steps
  • FSE Offline Support - steps
  1. What automated tests I added (or what prevented me from doing so)
  • These changes are covered by the existing Unit Tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced Aug 4, 2021
Merged
Merged
@antonis antonis self-assigned this Aug 4, 2021
@antonis antonis requested a review from chipsnyder August 4, 2021 10:10
@antonis antonis mentioned this pull request Aug 4, 2021
Closed
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis mentioned this pull request Aug 4, 2021
Merged
3 tasks
Antonis Lilis added 2 commits September 1, 2021 13:59
@antonis antonis requested a review from mkevins September 1, 2021 11:11
@antonis antonis marked this pull request as ready for review September 1, 2021 11:11
mkevins
mkevins approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via: #15134 (review)

Thanks Antonis! LGTM!

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 2, 2021 •
edited
Loading

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@antonis antonis added this to the 18.2 milestone Sep 2, 2021
@antonis antonis merged commit daecb95 into develop Sep 2, 2021
@antonis antonis deleted the rnmobile/gallery-as-nested-image-blocks-editor-settings_v2 branch September 2, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@chipsnyder chipsnyder Awaiting requested review from chipsnyder

Assignees

@antonis antonis

Labels
[Type] Enhancement
Projects
None yet
Milestone
18.2
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @mkevins