Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the Gallery v2 Flag over from the editor #3793

Conversation

antonis
Copy link

@antonis antonis commented Aug 4, 2021

Related PRs

WordPress-Android: wordpress-mobile/WordPress-Android#15129
WordPress-FluxC-Android: wordpress-mobile/WordPress-FluxC-Android#2065
gutenberg: WordPress/gutenberg#33544

Description

This PR adds the Gallery v2 Flag to the EditorTheme to be passed down to the Editor

To test:
Check WordPress/gutenberg#33544

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis force-pushed the refactor/gallery-as-nested-image-blocks-editor-settings_v2_android branch from d90e217 to a7f59c4 Compare September 1, 2021 09:13
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 1, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis requested a review from mkevins September 1, 2021 11:12
@antonis antonis marked this pull request as ready for review September 1, 2021 11:12
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via: wordpress-mobile/WordPress-Android#15134 (review)

Thanks Antonis! LGTM!

Just need to update the reference to resolve conflicts.

@antonis
Copy link
Author

antonis commented Sep 2, 2021

Closing this PR in favour of the iOS PR

@antonis antonis closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants