-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable VideoPress block on iOS #20100
Conversation
@@ -713,6 +715,11 @@ - (BOOL)supportsTiledGallery | |||
return self.isHostedAtWPcom; | |||
} | |||
|
|||
- (BOOL)supportsVideoPress | |||
{ | |||
return self.isHostedAtWPcom; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled only on simple WordPress.com sites for now and added a task to the project board for this to eventually be changed to match the web.
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the installable build and noticed that I can add the VideoPress block to a post/page. However, if this block is only meant to be available in development mode (i.e. using __DEV__
flag), it should not be available in the installable builds.
Thanks for spotting this! I'll look into what's causing this. 🧐 |
@fluiddot, I've added a fix for this with this commit, thanks again for spotting this! No rush to re-review, I don't plan to begin the merge domino until next week 🙇♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the installable build and noticed that I can add the VideoPress block to a post/page. However, if this block is only meant to be available in development mode (i.e. using DEV flag), it should not be available in the installable builds.
As I mentioned in wordpress-mobile/gutenberg-mobile#5459 (review), the VideoPress block is no longer available for insertion, however, it's still being rendered as a regular block instead of an unsupported block.
Noting that I'm working to fix the failing builds. |
@fluiddot, the newest installable builds have finished generating now, whenever you have availability for taking another look. Thanks in advance! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
I checked that the VideoPress block is displayed as unsupported and that can be edited via UBE (Unsupported Block Editor) on Atomic sites.
NOTE: On Simple sites when using UBE, it shows a warning due to the block not being available on the site. This is expected as the block on the web hasn't been released yet to users.
Tested build pr20100-17ddbb8
on an iPhone 11 (iOS 15.4).
With this PR, the VideoPress block has been registered behind a DEV flag. The block itself is not complete or fully functional, but is intended to serve as a useful placeholder to be iterated on.
Related PRs
Gutenberg
: [RNMobile] Enable new block in Gutenberg Mobile WordPress/gutenberg#47836Gutenberg Mobile
: Register VideoPress block behind a DEV flag gutenberg-mobile#5459Jetpack
: [RNMobile] Register VideoPress block Automattic/jetpack#28812Android
: Enable VideoPress block on Android WordPress-Android#17928Testing
Please refer to the Gutenberg Mobile PR as the "central PR" with the most up-to-date testing instructions.
Regression Notes
As this is a new block that's been registered behind a DEV flag, it's hoped it won't have any impact on other blocks or areas of the editor. That said, it's always best to be careful and I manually smoke tested some other blocks (including the core video block) to check for any obvious issues.
No automated tests for now as this is the first step in a larger project. Tests related to this new block will come as it's worked on and functionality is added.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.