Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VideoPress block on iOS #20100

Merged
merged 9 commits into from
Feb 15, 2023
Merged

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Feb 8, 2023

With this PR, the VideoPress block has been registered behind a DEV flag. The block itself is not complete or fully functional, but is intended to serve as a useful placeholder to be iterated on.

Related PRs

Testing

Please refer to the Gutenberg Mobile PR as the "central PR" with the most up-to-date testing instructions.


Regression Notes

  1. Potential unintended areas of impact
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

As this is a new block that's been registered behind a DEV flag, it's hoped it won't have any impact on other blocks or areas of the editor. That said, it's always best to be careful and I manually smoke tested some other blocks (including the core video block) to check for any obvious issues.

  1. What automated tests I added (or what prevented me from doing so)

No automated tests for now as this is the first step in a larger project. Tests related to this new block will come as it's worked on and functionality is added.


PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB changed the title Enable support for the VideoPress block Enabled VideoPress block on iOS Feb 8, 2023
@SiobhyB SiobhyB added Gutenberg Editing and display of Gutenberg blocks. Posting/Editing Media labels Feb 8, 2023
@SiobhyB SiobhyB changed the title Enabled VideoPress block on iOS Enable VideoPress block on iOS Feb 8, 2023
@@ -713,6 +715,11 @@ - (BOOL)supportsTiledGallery
return self.isHostedAtWPcom;
}

- (BOOL)supportsVideoPress
{
return self.isHostedAtWPcom;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled only on simple WordPress.com sites for now and added a task to the project board for this to eventually be changed to match the web.

@SiobhyB SiobhyB marked this pull request as ready for review February 8, 2023 17:46
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20100-9f6320d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20100-9f6320d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the installable build and noticed that I can add the VideoPress block to a post/page. However, if this block is only meant to be available in development mode (i.e. using __DEV__ flag), it should not be available in the installable builds.

Podfile Outdated Show resolved Hide resolved
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 9, 2023

I tested the installable build and noticed that I can add the VideoPress block to a post/page. However, if this block is only meant to be available in development mode (i.e. using DEV flag), it should not be available in the installable builds.

Thanks for spotting this! I'll look into what's causing this. 🧐

@SiobhyB SiobhyB added this to the 21.8 milestone Feb 10, 2023
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 10, 2023

@fluiddot, I've added a fix for this with this commit, thanks again for spotting this! No rush to re-review, I don't plan to begin the merge domino until next week 🙇‍♀️

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the installable build and noticed that I can add the VideoPress block to a post/page. However, if this block is only meant to be available in development mode (i.e. using DEV flag), it should not be available in the installable builds.

As I mentioned in wordpress-mobile/gutenberg-mobile#5459 (review), the VideoPress block is no longer available for insertion, however, it's still being rendered as a regular block instead of an unsupported block.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 14, 2023

Noting that I'm working to fix the failing builds.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 14, 2023

@fluiddot, the newest installable builds have finished generating now, whenever you have availability for taking another look. Thanks in advance! :)

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

I checked that the VideoPress block is displayed as unsupported and that can be edited via UBE (Unsupported Block Editor) on Atomic sites.

NOTE: On Simple sites when using UBE, it shows a warning due to the block not being available on the site. This is expected as the block on the web hasn't been released yet to users.

Tested build pr20100-17ddbb8 on an iPhone 11 (iOS 15.4).

@SiobhyB SiobhyB merged commit a502d28 into trunk Feb 15, 2023
@SiobhyB SiobhyB deleted the gutenberg/register-videopress-block branch February 15, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Media Posting/Editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants