Register VideoPress block behind a DEV flag #5459

SiobhyB · 2023-02-08T11:00:26Z

With this PR, the VideoPress block has been registered behind a DEV flag. The block itself is not complete or fully functional, but is intended to serve as a useful placeholder that to be iterated on.

Related PRs

Gutenberg: [RNMobile] Enable new block in Gutenberg Mobile WordPress/gutenberg#47836
Jetpack: [RNMobile] Register VideoPress block Automattic/jetpack#28812
iOS: Enable VideoPress block on iOS WordPress-iOS#20100
Android: Enable VideoPress block on Android WordPress-Android#17928

To Test

Run the editor locally with both Android and iOS, then go through the following checks:

Verify that the VideoPress block can be inserted into a post via the block inserter, the block inserter search, and the slash inserter.
Verify that the block is only visible when running via your local development environment, it shouldn't be visible with the PR's associated installable build.
Verify that all automated tests pass and that there are no obvious errors associated with the addition of the block.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This reverts commit c4f8198.

peril-wordpress-mobile · 2023-02-08T11:32:41Z

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

renatoagds

LGTM

fluiddot

LGTM 🎊 !

NOTE: I've restarted the CI jobs because the CircleCI ones didn't start in the last commit.

src/block-support/supported-blocks.json

SiobhyB · 2023-02-10T14:10:07Z

src/jetpack-editor-setup.js

@@ -85,9 +85,16 @@ export function registerJetpackBlocks( { capabilities } ) {
 		capabilities.tiledGalleryBlock,
 		'jetpack/tiled-gallery'
 	);
+	hideBlockByCapability(
+		__DEV__ && capabilities.videoPressBlock,


Adding the __DEV__ flag here (vs. only as part of the supportedJetpackBlocks object, like the Tiled Gallery block) because the VideoPress block lives in a separate package and is never passed to this function for checking availability.

Good catch! I checked this change using the iOS installable build and although I can't insert the VideoPress block, it's still being rendered. The main reason for this is that hideBlockByCapability function hides the block but doesn't prevent being registered, hence being rendered as a regular block instead of unsupported.

As a workaround, we could implement a native version of videopress/src/client/block-editor/blocks/video/index.ts file (where the block is registered), and either:

Expose a registerVideoPressBlock function that registers the block in order to be used in Gutenberg Mobile.

Add the needed checks to conditionally register the block.

Ah, thank you for spotting that, I'll work on a registerVideoPressBlock function.

The VideoPress block was previously displaying in all builds, as the __DEV__ flag had been incorrectly added to the 'supportedJetpackBlocks' object. As the block belongs in a different packages to 'regular' Jetpack blocks, it was not passed to the 'register-jetpack-block.native.js' file, so didn't go through the usual availability checks. As a way around this, the __DEV__ flag has been added alongside the 'hideBlockByCapability' function. The unnecessary inclusion of VideoPress in the 'supportedJetpackBlocks' object has been removed.

fluiddot · 2023-02-13T11:00:26Z

src/jetpack-editor-setup.js

@@ -85,9 +85,16 @@ export function registerJetpackBlocks( { capabilities } ) {
 		capabilities.tiledGalleryBlock,
 		'jetpack/tiled-gallery'
 	);
+	hideBlockByCapability(
+		__DEV__ && capabilities.videoPressBlock,


Good catch! I checked this change using the iOS installable build and although I can't insert the VideoPress block, it's still being rendered. The main reason for this is that hideBlockByCapability function hides the block but doesn't prevent being registered, hence being rendered as a regular block instead of unsupported.

As a workaround, we could implement a native version of videopress/src/client/block-editor/blocks/video/index.ts file (where the block is registered), and either:

Expose a registerVideoPressBlock function that registers the block in order to be used in Gutenberg Mobile.

Add the needed checks to conditionally register the block.

As we're now checking for the block's availability in the Jetpack repository, the conditional being removed with this commit is now redundant.

fluiddot

LGTM 🎊 !

VideoPress block is displayed as unsupported in the installable builds (i.e. production version) ✅ .
VideoPress block is rendered when using local development environment ✅ .

Siobhan added 5 commits February 8, 2023 10:54

Update Jetpack submodule reference

c4f8198

Update Gutenberg submodule reference

9d774b3

Revert "Update Jetpack submodule reference"

b93ef4b

This reverts commit c4f8198.

Update Jetpack submodule reference

045022d

Register VideoPress block

04a6bbc

Siobhan added 3 commits February 8, 2023 11:33

Update Gutenberg submodule reference

33ce5ec

Merge branch 'trunk' into register-videopress-block

00a5cea

Fix code formatting

23e66db

SiobhyB mentioned this pull request Feb 8, 2023

[RNMobile] Enable new block in Gutenberg Mobile WordPress/gutenberg#47836

Merged

Siobhan added 3 commits February 8, 2023 11:47

Add tests for VideoPress block

a1bd0a5

Update Jetpack submodule reference

075f914

Update reference to Gutenberg submodule

6bca0e9

SiobhyB force-pushed the register-videopress-block branch from 2b28464 to a205ac6 Compare February 8, 2023 14:33

Apply changes from bundle

a205ac6

SiobhyB changed the title ~~Register videopress block~~ Register VideoPress block behind a DEV flag Feb 8, 2023

SiobhyB added the Jetpack Bug or feature related to Jetpack label Feb 8, 2023

This was referenced Feb 8, 2023

[RNMobile] Register VideoPress block Automattic/jetpack#28812

Merged

Enable VideoPress block on iOS wordpress-mobile/WordPress-iOS#20100

Merged

Siobhan added 3 commits February 8, 2023 15:40

Update Gutenberg submodule reference

f997a4e

Update Gutenberg submodule reference

97b9b06

Apply changes to bundle

0b4b05d

SiobhyB mentioned this pull request Feb 8, 2023

Enable VideoPress block on Android wordpress-mobile/WordPress-Android#17928

Merged

3 tasks

SiobhyB added the Media label Feb 8, 2023

SiobhyB requested review from fluiddot, jhnstn and renatoagds February 8, 2023 17:58

SiobhyB marked this pull request as ready for review February 8, 2023 19:04

renatoagds approved these changes Feb 8, 2023

View reviewed changes

renatoagds mentioned this pull request Feb 8, 2023

[Spike] Explore adding VideoPress block to Gutenberg Mobile #5431

Closed

renatoagds and others added 2 commits February 8, 2023 23:26

Jetpack: Update reference

364d743

Trigger CI

c2ad65c

fluiddot approved these changes Feb 9, 2023

View reviewed changes

src/block-support/supported-blocks.json Outdated Show resolved Hide resolved

SiobhyB commented Feb 10, 2023

View reviewed changes

SiobhyB force-pushed the register-videopress-block branch from 5fe7860 to 2209d48 Compare February 13, 2023 09:29

Siobhan added 5 commits February 13, 2023 09:30

Move blocks to 'devOnly' section

c957912

Update iOS bundle with latest changes

0f38528

Restore code for testing block's availability

518cb39

Apply changes to iOS bundle

81826df

fluiddot requested changes Feb 13, 2023

View reviewed changes

Siobhan added 3 commits February 13, 2023 21:30

Remove redundant _DEV_ flag

0b04147

As we're now checking for the block's availability in the Jetpack repository, the conditional being removed with this commit is now redundant.

Update Jetpack submodule reference

62902ca

Apply changes to iOS bundle

2df3df6

SiobhyB requested a review from fluiddot February 13, 2023 22:48

fluiddot approved these changes Feb 14, 2023

View reviewed changes

Siobhan added 7 commits February 14, 2023 16:32

Update Jetpack reference

370a468

Apply changes to iOS bundle

95ef3ed

Update Jetpack submodule reference

cd4d471

Update Gutenberg submodule reference

1e104ad

Apply changes to iOS bundle

427b7d6

Apply changes to iOS bundle

bf7e3e9

Apply changes to iOS bundle

bdbb5e7

SiobhyB merged commit a3b9884 into trunk Feb 15, 2023

SiobhyB deleted the register-videopress-block branch February 15, 2023 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register VideoPress block behind a DEV flag #5459

Register VideoPress block behind a DEV flag #5459

SiobhyB commented Feb 8, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Feb 8, 2023 •

edited

Loading

renatoagds left a comment

fluiddot left a comment

SiobhyB Feb 10, 2023 •

edited

Loading

fluiddot Feb 13, 2023

SiobhyB Feb 13, 2023

fluiddot Feb 13, 2023

fluiddot left a comment

Register VideoPress block behind a DEV flag #5459

Register VideoPress block behind a DEV flag #5459

Conversation

SiobhyB commented Feb 8, 2023 • edited Loading

Related PRs

To Test

peril-wordpress-mobile bot commented Feb 8, 2023 • edited Loading

renatoagds left a comment

Choose a reason for hiding this comment

fluiddot left a comment

Choose a reason for hiding this comment

SiobhyB Feb 10, 2023 • edited Loading

Choose a reason for hiding this comment

fluiddot Feb 13, 2023

Choose a reason for hiding this comment

SiobhyB Feb 13, 2023

Choose a reason for hiding this comment

fluiddot Feb 13, 2023

Choose a reason for hiding this comment

fluiddot left a comment

Choose a reason for hiding this comment

SiobhyB commented Feb 8, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Feb 8, 2023 •

edited

Loading

SiobhyB Feb 10, 2023 •

edited

Loading