CircleCI - Update configuration to make builds once and share between jobs #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
improve-order-of-ci-jobs
branch
from
6099256
to
8cf3b59
Compare
geriux
changed the title
geriux
commented
Feb 13, 2023
| @@ -137,7 +160,7 @@ parameters: | |||
| linux-machine-image: | |||
| type: string | |||
| # Latest supported ubuntu image from https://circleci.com/docs/2.0/configuration-reference/#available-machine-images | |||
| default: "ubuntu-2004:202010-01" | |||
| default: "ubuntu-2004:2022.10.1" | |||
There was a problem hiding this comment.
I saw we were using a pretty old image so I updated it to the last one. I haven't seen any issues with the update.
fluiddot
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
LGTM 🎊 ! I checked the new duration of E2E tests and this is a huge improvement, amazing work @geriux 🏅 !
As shared in WordPress/gutenberg#48026 (review), I checked the E2E tests and all succeeded. I added some minor comments/suggestions but shouldn't block the merge of this PR.
|
FYI I've updated |
- Updating the naming structure we use for the cache keys - Add new jobs to make app builds before running E2E tests - Adds the requires param for a few jobs that will depend on test checks and builds steps to succeed before running - A new npm install comand that will not run postinstall scripts to speed up running time - Updates NVM - Updates the linux image version
geriux
force-pushed
the
improve-order-of-ci-jobs
branch
from
991b254
to
26fbf22
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
This PR updates the CircleCI configuration to add two new steps to create the builds separately so they can be shared between jobs. The reasoning for this apart from optimizing the time it takes to run and credits usage, it's that we were reaching the limit amount to upload artifacts in the 15 mins timeframe, which is limited to 5.
There's no need to upload the build for each platform in each job (Canaries, Full tests) so now it will just do it once per platform.
It also adds
requiressteps for some jobs, now that the builds are done separately we can't run tests until those are uploaded.This is also a pre-work for the visual regression tests where we will be introducing a new job for them so they run in parallel as the other E2E tests to save up running time.
Besides that, it also adds
npm-install-without-scriptswhich will install the packages without thepostinstallscripts to save quite a bit of time since we will only need some packages to run the tests like appium, etc.The key names for the
NPM cachejobs are also updated to just use thearchvalue since we use two different images, we don't need to store this per job name.Finally, it updates the
nvmcommand to use the latest versionv0.39.3.Our current workflow in
trunkis:This is how the test will run with this PR:
To test CI checks should pass.
PR submission checklist: