CircleCI checks - Fix running Full tests twice in certain branches

[geriux]

This is a follow-up of #5462 where it was causing an issue where the Test iOS on Device - Full and Test Android on Device - Full steps would get triggered for release, dependabot, and trunk branches when it shouldn't, as there are steps specifically for those branches.

Making the Optional UI Tests as required and that requirement being ignored for those branches would trigger full tests to run twice. This PR addresses that issue.

You could see this happening in the trunk branch after the recent merge.

To test
CI checks should pass.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[fluiddot]

LGTM 🎊 !

Ah, good catch. I completely overlooked this issue when reviewing #5462. Thanks for fixing it @geriux 🙇 !

On a different note, I noticed that we have a bit of redundancy on the jobs for trunk, dependabot, and release branches (reference). Not sure why we have one job for each one but seems we could unify them into one using the only filter, I'll create a quick PR as a follow-up on this.

[geriux]

Ah, good catch. I completely overlooked this issue when reviewing #5462. Thanks for fixing it @geriux 🙇 !

No worries I thought that by having the requirement was enough 😅

On a different note, I noticed that we have a bit of redundancy on the jobs for trunk, dependabot, and release branches (reference). Not sure why we have one job for each one but seems we could unify them into one using the only filter, I'll create a quick PR as a follow-up on this.

Yeah, I agree! Thanks for working on that!

[fluiddot]

On a different note, I noticed that we have a bit of redundancy on the jobs for trunk, dependabot, and release branches (reference). Not sure why we have one job for each one but seems we could unify them into one using the only filter, I'll create a quick PR as a follow-up on this.

Here is the PR. @geriux I assigned you as a reviewer, the change is an enhancement so please don't prioritize the review. Thanks 🙇 !