Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the CI jobs that run the full E2E test suites automatically #5482

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 16, 2023

The full E2E test suites are automatically triggered for the following specific branches:

  • trunk
  • Dependabot branches (e.g. dependabot/submodules/gutenberg-caab0fe)
  • Release branches (e.g. release/1.88.0)

We define a single job for each branch but the same steps are executed (reference). For this reason, I'd propose unifying them into a single job for each platform to simplify the CircleCI configuration.

To test

Regular branch

Dependabot branch

Release branch

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Testing Anything related to automated tests label Feb 16, 2023
@fluiddot fluiddot requested a review from geriux February 16, 2023 10:08
@fluiddot fluiddot self-assigned this Feb 16, 2023
@fluiddot fluiddot force-pushed the unify-full-test-suite-ci-jobs branch from 41f9db5 to 5456146 Compare February 16, 2023 10:20
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review February 16, 2023 10:21
@fluiddot fluiddot added the [Type] Enhancement Improves a current area of the editor label Feb 16, 2023
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this, it looks way better now 🚀

@fluiddot fluiddot merged commit 5c66759 into trunk Feb 20, 2023
@fluiddot fluiddot deleted the unify-full-test-suite-ci-jobs branch February 20, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants