maint: pin matplotlib maximal supported version #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
pin_matplotib_max
branch
2 times, most recently
from
6cf0bce
to
178746a
Compare
Xarthisius
reviewed
Mar 26, 2021
| @@ -5,7 +5,6 @@ fastcache~=1.0.2 | |||
| glueviz~=0.13.3 | |||
| h5py~=3.1.0 | |||
| ipython~=7.6.1 | |||
| matplotlib~=3.3 | |||
There was a problem hiding this comment.
Please don't remove that. Change it to matplotlib<3.4.0 instead.
There was a problem hiding this comment.
Fine for now, but FYI I'm trying to move yt to a better place in terms of dependency specifications, so I'll be working on this later.
There was a problem hiding this comment.
@neutrinoceros Before you dig any deeper on that, can we have a video conference about it so that (at least) I can understand it? I'm anxious about moving too much since the pytest stuff is startign to get pulled in, and we don't want to have to move stuff on jenkins etc around too much just yet.
neutrinoceros
force-pushed
the
pin_matplotib_max
branch
from
178746a
to
92d6cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a hot fix for failing answer-tests following the release of matplotlib 3.4.0
Obviously this boundary should be lifted in the near future.