Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: pin matplotlib maximal supported version #3150

Merged
merged 1 commit into from
Mar 26, 2021
Merged

maint: pin matplotlib maximal supported version #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def has_ext_modules(self):
packages=find_packages(),
include_package_data=True,
install_requires=[
"matplotlib>=2.0.2",
"matplotlib>=2.0.2,<3.4",
"setuptools>=19.6",
"sympy>=1.2",
"numpy>=1.10.4",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ fastcache~=1.0.2
glueviz~=0.13.3
h5py~=3.1.0
ipython~=7.6.1
matplotlib~=3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove that. Change it to matplotlib<3.4.0 instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, but FYI I'm trying to move yt to a better place in terms of dependency specifications, so I'll be working on this later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neutrinoceros Before you dig any deeper on that, can we have a video conference about it so that (at least) I can understand it? I'm anxious about moving too much since the pytest stuff is startign to get pulled in, and we don't want to have to move stuff on jenkins etc around too much just yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !

matplotlib<3.4
nose-timer~=1.0.0
nose~=1.3.7
pandas~=1.1.2
Expand Down