Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ftp package #143

Merged
merged 63 commits into from
Aug 1, 2023
Merged

Migrate ftp package #143

merged 63 commits into from
Aug 1, 2023

Conversation

tpluscode
Copy link
Contributor

No description provided.

bergos and others added 30 commits September 11, 2019 20:40
Avoid swallowing errors from FTP client
`createReadStream` has an issue on Linux where consuming the stream runs
forever and no data is actually consumed.

Replacing it with `getStream` and a custom duplex stream implementation.
Add `privateKey` and `passphrase` options to SFTP client.
Add support for SFTP SSH key authentication
docs: document package operations in README
Our PR has been merged. We don't need to depend on a fork anymore.
fix: renamed/added manifest.ttl and added content
fix: use object mode in move stream wrapper
@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

⚠️ No Changeset found

Latest commit: ffdf6c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ludovicm67
Copy link
Member

From what I can see, it looks good!

Can you configure the tests in the CI to also run the ones from barnard59-ftp package?

@tpluscode
Copy link
Contributor Author

Funny, I even added it to the wiki page and then did not follow that step :)

@tpluscode tpluscode merged commit 5a91a10 into master Aug 1, 2023
15 checks passed
@tpluscode tpluscode deleted the ftp branch August 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants