Further enhanced the syntax support #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Multi line pipe blocks support - wrapped tags: div: div Foo - inline JS (non Multiline) - Added vue-attributes - refac rules
bindings/*, parser.c must be checked in, too, otherwise GH Actions cannot build
I think the main change is checking for lexer->lookahead before doing lexer->get_column(lexer) since it was segfaulting in exactly that function.
fix: try to avoid segfaults in scanner.cc
Fix: fix comments not ending after dedents
Fix: fix newlines inside dot continues causing the next dedent to be …
Add syntax highlighting
mclaughlinconnor
force-pushed
the
master
branch
from
3b3c6f3
to
f2e5782
Compare
|
I was messing with the history to remove some dodgy commits and now I can't reopen... See #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise this is a pretty hefty PR, but I'm not sure what your thoughts are on this repo, or if you're planning on keeping in maintained.
I've added syntax support for nearly everything (I think anyway) -- there are a few small problems with some of the JS style attributes, etc., but I hope to have them sorted soon-ish.
If you'd rather, though (and I'm guessing this will be the case seeing as I've rewritten most of it, and to avoid any upstreaming requests), I can just "unfork" my repo to be maintained separately by me.
Let me know what your thoughts are :)