-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further enhanced the syntax support #4
Conversation
I don't think this is being maintained by @zealot128 anymore, as I've had a pull request pending since May 2022 with no response. Your best bet is to put in a pull request with the nvim-treesitter project itself to switch to your fork. |
@JulesNP @mclaughlinconnor ups, I didn't noticed this PR. The default notification was only on for Mentions/watched threads for both of your PR's. (Maybe because this is a fork itself...?) Will check out if it works for "my" pug files, and if yes, I see no issues to give you commit rights. I only forked it myself to make it work for my use cases anyway. It would be best for this repo to be part of @pugjs group, but I am not in contact with anyone from that team. |
On cursory glance it parses most of the vue-pug files that I took a look on. Will use the fork for a couple of workdays. |
@JulesNP No, my code doesn't fix your string quoting issue. I probably could have, but I didn't want to shamelessly steal your code :) I haven't tested the code, but I know for sure it will have conflicts. I think you'll also want to use the same code for |
Re living under @pugjs, I agree, but there doesn't seem to be much activity in the group. I'm not in contact with anyone either, but @ForbesLindesay is pretty active on Github, so maybe we'll get a response with his thoughts on moving this into the group. |
It doesn't fix my quoting issue, but everything else with this version is working well. I'll withdraw my pull request and resubmit an updated version once @mclaughlinconnor's changes are merged. |
Haven't noticed any regression in the highlighting of my Vue/pug files. Only some wording in the README is Angular only. Can you adjust that please? Now the grammar is not only useful for us Vue or Angular folks, but almost general purpose. |
Docs: reword readme to be more inclusive of non-angular developers
Awesome! Thanks for the huge contribution. |
Force pushed to #3 and now I can't reopen
I realise this is a pretty hefty PR, but I'm not sure what your thoughts are on this repo, or if you're planning on keeping in maintained.
I've added syntax support for nearly everything (I think anyway) -- there are a few small problems with some of the JS style attributes, etc., but I hope to have them sorted soon-ish.
If you'd rather, though (and I'm guessing this will be the case seeing as I've rewritten most of it, and to avoid any upstreaming requests), I can just "unfork" my repo to be maintained separately by me.
Let me know what your thoughts are :)