Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :210593] Out-of-bounds access in lib/updatehub/updatehub.c #26993

Closed
zephyrbot opened this issue Jul 20, 2020 · 1 comment · Fixed by #27223
Closed

[Coverity CID :210593] Out-of-bounds access in lib/updatehub/updatehub.c #26993

zephyrbot opened this issue Jul 20, 2020 · 1 comment · Fixed by #27223
Assignees
@nandojve
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/476fc405e7/lib/updatehub/updatehub.c

Category: Memory - corruptions
Function: cleanup_connection
Component: Other
CID: 210593

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Jul 20, 2020
@nandojve
Copy link
Member

CC @otavio

@nandojve nandojve mentioned this issue Jul 29, 2020
Merged
nandojve added a commit to UpdateHub/zephyr that referenced this issue Jul 30, 2020
@nandojve
lib: updatehub: Fix out-of-bounds access
7cbe1fe 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes zephyrproject-rtos#26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
nandojve added a commit to UpdateHub/zephyr that referenced this issue Jul 30, 2020
@nandojve
lib: updatehub: Fix out-of-bounds access
f006fd3 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes zephyrproject-rtos#26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
carlescufi pushed a commit that referenced this issue Jul 30, 2020
@nandojve @carlescufi
lib: updatehub: Fix out-of-bounds access
8683b47 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes #26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
@nandojve nandojve mentioned this issue Aug 2, 2020
Merged
@nandojve nandojve mentioned this issue Aug 30, 2020
Closed
nandojve added a commit to UpdateHub/zephyr that referenced this issue Aug 30, 2020
@nandojve
lib: updatehub: Fix out-of-bounds access
09ece89 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes zephyrproject-rtos#26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
nandojve added a commit to UpdateHub/zephyr that referenced this issue Aug 30, 2020
@nandojve
lib: updatehub: Fix out-of-bounds access
76e8d16 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes zephyrproject-rtos#26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
@nandojve nandojve mentioned this issue Aug 30, 2020
Closed
nashif pushed a commit that referenced this issue Nov 17, 2020
@nandojve @nashif
lib: updatehub: Fix out-of-bounds access
c2e60a4 
The struct pollfd context variable is not proper initialized and index
is out-of-bounds. Adjusts index to be inside scope boundary.

Fixes #26993.

Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nandojve nandojve

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: updatehub: Fix out-of-bounds access and add flash_img_init return value check UpdateHub/zephyr
2 participants
@nandojve @zephyrbot