lib: updatehub: Fix out-of-bounds access and add flash_img_init return value check #27223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
approved these changes
Jul 29, 2020
ceolin
reviewed
Jul 29, 2020
The struct pollfd context variable is not proper initialized and index is out-of-bounds. Adjusts index to be inside scope boundary. Fixes zephyrproject-rtos#26993. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
The flash_img_int return value is not checked for fail conditions. This can result on useless download attempts once image will not be properly recorded. Add return value check and on error execute default treatment. Fixes zephyrproject-rtos#26992. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
nandojve
force-pushed
the
topic/uhu-resource-out-of-bound
branch
from
8abd3ef
to
d035a6e
Compare
ceolin
approved these changes
Jul 30, 2020
jukkar
approved these changes
Jul 30, 2020
This was referenced Aug 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flash_img_int return value is not checked for fail conditions. This can result on useless download attempts once image will not be properly recorded. Add return value check and on error execute default treatment.
Fixes #26992.
The struct pollfd context variable is not proper initialized and index is out-of-bounds. Adjusts index to be inside scope boundary.
Fixes #26993.
CC: @otavio