Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest {CosmosDB-Preview} Incorporate stable changes for no-timestamp restore from #28034 and #28365 of the InAccount Restore of Deleted Database/Containers feature for SQL/Mongo/Table/Gremlin in az cosmosdb original: #7340 #7343

Conversation

AgarwalVivek
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

carjackson-msft and others added 30 commits February 7, 2024 17:30
(cherry picked from commit a28144517ad4022098561e83d8607c93933dd36c)
(cherry picked from commit 3d721cb)
(cherry picked from commit f4e6f01f99eb1299e8c536423f074e9832b71e16)
…th_ttl_disabled

Introduce disable_ttl parameter
This reverts commit d4f4abe.
Copy link

azure-client-tools-bot-prd bot commented Mar 4, 2024

❌Azure CLI Extensions Breaking Change Test
❌cosmosdb-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove cosmosdb create cmd cosmosdb create removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb create
1007 - ParaRemove cosmosdb restore cmd cosmosdb restore removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb restore
1007 - ParaRemove cosmosdb update cmd cosmosdb update removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb update
⚠️ 1001 - CmdAdd cosmosdb copy complete cmd cosmosdb copy complete added
⚠️ 1006 - ParaAdd cosmosdb copy create cmd cosmosdb copy create added parameter mode
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_partition_merge
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_per_region_per_partition_autoscale
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter public_network_access
⚠️ 1006 - ParaAdd cosmosdb gremlin database restore cmd cosmosdb gremlin database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb gremlin database restore cmd cosmosdb gremlin database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb gremlin graph restore cmd cosmosdb gremlin graph restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb gremlin graph restore cmd cosmosdb gremlin graph restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb mongodb collection restore cmd cosmosdb mongodb collection restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb mongodb collection restore cmd cosmosdb mongodb collection restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb mongodb database restore cmd cosmosdb mongodb database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb mongodb database restore cmd cosmosdb mongodb database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb restore cmd cosmosdb restore added parameter disable_ttl
⚠️ 1006 - ParaAdd cosmosdb restore cmd cosmosdb restore added parameter public_network_access
⚠️ 1006 - ParaAdd cosmosdb sql container restore cmd cosmosdb sql container restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb sql container restore cmd cosmosdb sql container restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb sql database restore cmd cosmosdb sql database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb sql database restore cmd cosmosdb sql database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb table restore cmd cosmosdb table restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb table restore cmd cosmosdb table restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_partition_merge
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_per_region_per_partition_autoscale
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter public_network_access

Copy link

Hi @AgarwalVivek,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @AgarwalVivek,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Thank you for your contribution AgarwalVivek! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 4, 2024
Copy link

gitguardian bot commented Mar 4, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
- Microsoft Azure Storage Account Key 583371c src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/recordings/test_cosmosdb_database.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@AgarwalVivek AgarwalVivek changed the title Fixing recordings Latest {CosmosDB-Preview} Incorporate stable changes for no-timestamp restore from #28034 and #28365 of the InAccount Restore of Deleted Database/Containers feature for SQL/Mongo/Table/Gremlin in az cosmosdb #7340 Mar 4, 2024
@AgarwalVivek AgarwalVivek changed the title Latest {CosmosDB-Preview} Incorporate stable changes for no-timestamp restore from #28034 and #28365 of the InAccount Restore of Deleted Database/Containers feature for SQL/Mongo/Table/Gremlin in az cosmosdb #7340 Latest {CosmosDB-Preview} Incorporate stable changes for no-timestamp restore from #28034 and #28365 of the InAccount Restore of Deleted Database/Containers feature for SQL/Mongo/Table/Gremlin in az cosmosdb original: #7340 Mar 4, 2024
AgarwalVivek added a commit to carjackson-msft/azure-cli-extensions that referenced this pull request Mar 6, 2024
…ntrestore-notimestamprestore-preview

 Incorporate stable changes for no-timestamp restore from #28034 and #28365 of the InAccount Restore of Deleted Database/Containers feature for SQL/Mongo/Table/Gremlin in az cosmosdb Azure#7343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants