Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HealthInsights] update Java/csharp model client names #28978

Conversation

asaflevi-ms
Copy link
Member

Data Plane API Specification Update Pull Request

PR to update mode client names in Java and C#.
No effect to the OpenAPI Spec.

  • a private preview
  • a public preview
  • [V] GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Copy link

openapi-pipeline-app bot commented May 5, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 5, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 5, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 0af0d5f2d7a7ab57f680617d7f229a8579b014d5. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-healthinsights-radiologyinsights [Preview SDK Changes]
    • azure-healthinsights-radiologyinsights-1.0.0.zip
    • azure_healthinsights_radiologyinsights-1.0.0-py3-none-any.whl
    info	[Changelog] data-plan skip changelog generation temporarily
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 0af0d5f2d7a7ab57f680617d7f229a8579b014d5. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-health-insights-radiologyinsights [Preview SDK Changes]
    • pom.xml
    • azure-health-insights-radiologyinsights-1.0.0-beta.2-sources.jar
    • azure-health-insights-radiologyinsights-1.0.0-beta.2.jar
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 0af0d5f2d7a7ab57f680617d7f229a8579b014d5. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  131 |                GeneratePackage `
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk. exit code: False
  • Azure.Health.Insights.RadiologyInsights [Preview SDK Changes]
    • Azure.Health.Insights.RadiologyInsights.1.0.0-alpha.20240505.1.nupkg
    info	[Changelog]
️🔄 azure-sdk-for-js inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 5, 2024

Generated ApiView

Language Package Name ApiView Link
Python azure-healthinsights-radiologyinsights Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Java azure-health-insights-radiologyinsights https://apiview.dev/Assemblies/Review/c48b47bd12a6493aa27b2cec58f9e54e?revisionId=d2d41c6fcb954bddae7f85fa1c300a04
.Net Azure.Health.Insights.RadiologyInsights https://apiview.dev/Assemblies/Review/d43daa369e2a49c0bb24a37339ceacea?revisionId=4902d11fe35d4180a1397e145645ce6e
TypeSpec HealthInsights.OpenAPI https://apiview.dev/Assemblies/Review/652055157260479f95c0f6ec96285993?revisionId=ef72cec475704eb5a94c57a6d41fc1fa

@weidongxu-microsoft weidongxu-microsoft merged commit a8698bb into Azure:main May 6, 2024
30 of 32 checks passed
fhaghbin-msft added a commit that referenced this pull request May 6, 2024
* [suppressions.yaml] Create shared component "get-suppressions" (#28927)

- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes #28069

* fix: Java/csharp model client names (#28978)

* Added beta4

* added readme

* Adding Hold/Unhold (#28853)

* added missing events (#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix format

* Fix error

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
heaths pushed a commit that referenced this pull request May 28, 2024
* Added beta4

* added readme

* Adding Hold/Unhold (#28853)

* added missing events (#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix based on feedbacks (#28986)

* Fhaghbin/error (#28987)

* [suppressions.yaml] Create shared component "get-suppressions" (#28927)

- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes #28069

* fix: Java/csharp model client names (#28978)

* Added beta4

* added readme

* Adding Hold/Unhold (#28853)

* added missing events (#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix format

* Fix error

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix pretier (#28990)

* Add BETA4 changes for transcription public preview (#28993)

* Add beta4 transcription feedback rework

* Add transcription beta4 examples

* Fix prettier

* Fix StopTranscription response code

* Fix errors (#29005)

* Fix spelling (#29006)

* Fix the description (#29037)

* Added suppression for LroExtension (#29072)

* rename mediaStreamingUpdateResult to mediaStreamingUpdate (#29090)

* [Call Automation] Create Connect interface (#29075)

* update swagger and add sample for Connect

* update description

* add description for call locator

* update description for connectFailed event

* rename ConnectCall to Connect in example

* update description

* fix style

* adding operation context

* revert renaming mediaStreamingUpdateResult

* fix example

* make change to re-trigger pipelines

* add back the rename from base branch

---------

Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>

---------

Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com>
Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* Added beta4

* added readme

* Adding Hold/Unhold (Azure#28853)

* added missing events (Azure#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (Azure#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix based on feedbacks (Azure#28986)

* Fhaghbin/error (Azure#28987)

* [suppressions.yaml] Create shared component "get-suppressions" (Azure#28927)

- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes Azure#28069

* fix: Java/csharp model client names (Azure#28978)

* Added beta4

* added readme

* Adding Hold/Unhold (Azure#28853)

* added missing events (Azure#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (Azure#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix format

* Fix error

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix pretier (Azure#28990)

* Add BETA4 changes for transcription public preview (Azure#28993)

* Add beta4 transcription feedback rework

* Add transcription beta4 examples

* Fix prettier

* Fix StopTranscription response code

* Fix errors (Azure#29005)

* Fix spelling (Azure#29006)

* Fix the description (Azure#29037)

* Added suppression for LroExtension (Azure#29072)

* rename mediaStreamingUpdateResult to mediaStreamingUpdate (Azure#29090)

* [Call Automation] Create Connect interface (Azure#29075)

* update swagger and add sample for Connect

* update description

* add description for call locator

* update description for connectFailed event

* rename ConnectCall to Connect in example

* update description

* fix style

* adding operation context

* revert renaming mediaStreamingUpdateResult

* fix example

* make change to re-trigger pipelines

* add back the rename from base branch

---------

Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>

---------

Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com>
Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants