Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fhaghbin/error #28987

Merged
merged 11 commits into from
May 6, 2024
Merged

Fhaghbin/error #28987

merged 11 commits into from
May 6, 2024

Conversation

fhaghbin-msft
Copy link
Member

@fhaghbin-msft fhaghbin-msft commented May 6, 2024

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

mikeharder and others added 10 commits May 4, 2024 00:02
- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes #28069
…ller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format
* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
@fhaghbin-msft fhaghbin-msft requested review from vicancy and scgbear and removed request for a team May 6, 2024 16:27
Copy link

openapi-pipeline-app bot commented May 6, 2024

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Copy link

openapi-pipeline-app bot commented May 6, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⌛Breaking Change(Cross-Version) pending [Detail]
️⌛LintDiff pending [Detail]
️⌛Avocado pending [Detail]
️⌛SwaggerAPIView pending [Detail]
️⌛TypeSpecAPIView pending [Detail]
️⌛ModelValidation pending [Detail]
️⌛SemanticValidation pending [Detail]
️⌛SpellCheck pending [Detail]
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 6, 2024

Swagger Generation Artifacts

️⌛ApiDocPreview pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 6, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@fhaghbin-msft fhaghbin-msft merged commit 2326e91 into callautomation/beta4 May 6, 2024
8 of 20 checks passed
@fhaghbin-msft fhaghbin-msft deleted the fhaghbin/error branch May 6, 2024 17:05
heaths pushed a commit that referenced this pull request May 28, 2024
* Added beta4

* added readme

* Adding Hold/Unhold (#28853)

* added missing events (#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix based on feedbacks (#28986)

* Fhaghbin/error (#28987)

* [suppressions.yaml] Create shared component "get-suppressions" (#28927)

- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes #28069

* fix: Java/csharp model client names (#28978)

* Added beta4

* added readme

* Adding Hold/Unhold (#28853)

* added missing events (#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix format

* Fix error

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix pretier (#28990)

* Add BETA4 changes for transcription public preview (#28993)

* Add beta4 transcription feedback rework

* Add transcription beta4 examples

* Fix prettier

* Fix StopTranscription response code

* Fix errors (#29005)

* Fix spelling (#29006)

* Fix the description (#29037)

* Added suppression for LroExtension (#29072)

* rename mediaStreamingUpdateResult to mediaStreamingUpdate (#29090)

* [Call Automation] Create Connect interface (#29075)

* update swagger and add sample for Connect

* update description

* add description for call locator

* update description for connectFailed event

* rename ConnectCall to Connect in example

* update description

* fix style

* adding operation context

* revert renaming mediaStreamingUpdateResult

* fix example

* make change to re-trigger pipelines

* add back the rename from base branch

---------

Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>

---------

Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com>
Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* Added beta4

* added readme

* Adding Hold/Unhold (Azure#28853)

* added missing events (Azure#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (Azure#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix based on feedbacks (Azure#28986)

* Fhaghbin/error (Azure#28987)

* [suppressions.yaml] Create shared component "get-suppressions" (Azure#28927)

- Usage: `npx get-suppressions <tool-name> <path-to-file>`
- Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty)
- Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json`
- Fixes Azure#28069

* fix: Java/csharp model client names (Azure#28978)

* Added beta4

* added readme

* Adding Hold/Unhold (Azure#28853)

* added missing events (Azure#28866)

* Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895)

* Add transcription APIs to beta4 controller

* Fix the spec file

* Fix the json format

* Update swagger with InterruptCallMediaOperation flag fix (Azure#28925)

* update swagger with interrupt call media operation flag

* ran prettier to fix indentation

---------

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix format

* Fix error

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Fix pretier (Azure#28990)

* Add BETA4 changes for transcription public preview (Azure#28993)

* Add beta4 transcription feedback rework

* Add transcription beta4 examples

* Fix prettier

* Fix StopTranscription response code

* Fix errors (Azure#29005)

* Fix spelling (Azure#29006)

* Fix the description (Azure#29037)

* Added suppression for LroExtension (Azure#29072)

* rename mediaStreamingUpdateResult to mediaStreamingUpdate (Azure#29090)

* [Call Automation] Create Connect interface (Azure#29075)

* update swagger and add sample for Connect

* update description

* add description for call locator

* update description for connectFailed event

* rename ConnectCall to Connect in example

* update description

* fix style

* adding operation context

* revert renaming mediaStreamingUpdateResult

* fix example

* make change to re-trigger pipelines

* add back the rename from base branch

---------

Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>

---------

Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com>
Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants