-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fhaghbin/error #28987
Merged
Merged
Fhaghbin/error #28987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Usage: `npx get-suppressions <tool-name> <path-to-file>` - Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty) - Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json` - Fixes #28069
…ller (#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format
* update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
fhaghbin-msft
requested review from
weshaggard,
mikeharder,
konrad-jamrozik and
a team
as code owners
May 6, 2024 16:27
fhaghbin-msft
requested review from
vicancy and
scgbear
and removed request for
a team
May 6, 2024 16:27
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
Swagger Validation Report
|
Swagger Generation Artifacts
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
This was referenced May 6, 2024
Closed
Closed
heaths
pushed a commit
that referenced
this pull request
May 28, 2024
* Added beta4 * added readme * Adding Hold/Unhold (#28853) * added missing events (#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix based on feedbacks (#28986) * Fhaghbin/error (#28987) * [suppressions.yaml] Create shared component "get-suppressions" (#28927) - Usage: `npx get-suppressions <tool-name> <path-to-file>` - Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty) - Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json` - Fixes #28069 * fix: Java/csharp model client names (#28978) * Added beta4 * added readme * Adding Hold/Unhold (#28853) * added missing events (#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix format * Fix error --------- Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix pretier (#28990) * Add BETA4 changes for transcription public preview (#28993) * Add beta4 transcription feedback rework * Add transcription beta4 examples * Fix prettier * Fix StopTranscription response code * Fix errors (#29005) * Fix spelling (#29006) * Fix the description (#29037) * Added suppression for LroExtension (#29072) * rename mediaStreamingUpdateResult to mediaStreamingUpdate (#29090) * [Call Automation] Create Connect interface (#29075) * update swagger and add sample for Connect * update description * add description for call locator * update description for connectFailed event * rename ConnectCall to Connect in example * update description * fix style * adding operation context * revert renaming mediaStreamingUpdateResult * fix example * make change to re-trigger pipelines * add back the rename from base branch --------- Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com> --------- Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com> Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Added beta4 * added readme * Adding Hold/Unhold (Azure#28853) * added missing events (Azure#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (Azure#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix based on feedbacks (Azure#28986) * Fhaghbin/error (Azure#28987) * [suppressions.yaml] Create shared component "get-suppressions" (Azure#28927) - Usage: `npx get-suppressions <tool-name> <path-to-file>` - Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty) - Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json` - Fixes Azure#28069 * fix: Java/csharp model client names (Azure#28978) * Added beta4 * added readme * Adding Hold/Unhold (Azure#28853) * added missing events (Azure#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (Azure#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix format * Fix error --------- Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix pretier (Azure#28990) * Add BETA4 changes for transcription public preview (Azure#28993) * Add beta4 transcription feedback rework * Add transcription beta4 examples * Fix prettier * Fix StopTranscription response code * Fix errors (Azure#29005) * Fix spelling (Azure#29006) * Fix the description (Azure#29037) * Added suppression for LroExtension (Azure#29072) * rename mediaStreamingUpdateResult to mediaStreamingUpdate (Azure#29090) * [Call Automation] Create Connect interface (Azure#29075) * update swagger and add sample for Connect * update description * add description for call locator * update description for connectFailed event * rename ConnectCall to Connect in example * update description * fix style * adding operation context * revert renaming mediaStreamingUpdateResult * fix example * make change to re-trigger pipelines * add back the rename from base branch --------- Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com> --------- Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com> Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.