Fix based on feedbacks #28986
Merged
Fix based on feedbacks #28986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhaghbin-msft
requested review from
DominikMe and
MushMal
and removed request for
a team
|
PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
|
PR validation pipeline started successfully. This comment will be populated with the 'Swagger Validation Report' |
|
PR validation pipeline started successfully. This comment will be populated with the 'Swagger Generation Artifacts' report |
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
heaths
pushed a commit
that referenced
this pull request
May 28, 2024
* Added beta4 * added readme * Adding Hold/Unhold (#28853) * added missing events (#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix based on feedbacks (#28986) * Fhaghbin/error (#28987) * [suppressions.yaml] Create shared component "get-suppressions" (#28927) - Usage: `npx get-suppressions <tool-name> <path-to-file>` - Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty) - Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json` - Fixes #28069 * fix: Java/csharp model client names (#28978) * Added beta4 * added readme * Adding Hold/Unhold (#28853) * added missing events (#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix format * Fix error --------- Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix pretier (#28990) * Add BETA4 changes for transcription public preview (#28993) * Add beta4 transcription feedback rework * Add transcription beta4 examples * Fix prettier * Fix StopTranscription response code * Fix errors (#29005) * Fix spelling (#29006) * Fix the description (#29037) * Added suppression for LroExtension (#29072) * rename mediaStreamingUpdateResult to mediaStreamingUpdate (#29090) * [Call Automation] Create Connect interface (#29075) * update swagger and add sample for Connect * update description * add description for call locator * update description for connectFailed event * rename ConnectCall to Connect in example * update description * fix style * adding operation context * revert renaming mediaStreamingUpdateResult * fix example * make change to re-trigger pipelines * add back the rename from base branch --------- Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com> --------- Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com> Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Added beta4 * added readme * Adding Hold/Unhold (Azure#28853) * added missing events (Azure#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (Azure#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix based on feedbacks (Azure#28986) * Fhaghbin/error (Azure#28987) * [suppressions.yaml] Create shared component "get-suppressions" (Azure#28927) - Usage: `npx get-suppressions <tool-name> <path-to-file>` - Returns: JSON array of suppressions, with specified tool name, applying to file (may be empty) - Example: `npm get-suppressions TypeSpecRequirement specification/foo/data-plane/Foo/stable/2023-01-01/Foo.json` - Fixes Azure#28069 * fix: Java/csharp model client names (Azure#28978) * Added beta4 * added readme * Adding Hold/Unhold (Azure#28853) * added missing events (Azure#28866) * Add transcription start, stop, update, get state APIs to beta4 controller (Azure#28895) * Add transcription APIs to beta4 controller * Fix the spec file * Fix the json format * Update swagger with InterruptCallMediaOperation flag fix (Azure#28925) * update swagger with interrupt call media operation flag * ran prettier to fix indentation --------- Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix format * Fix error --------- Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> * Fix pretier (Azure#28990) * Add BETA4 changes for transcription public preview (Azure#28993) * Add beta4 transcription feedback rework * Add transcription beta4 examples * Fix prettier * Fix StopTranscription response code * Fix errors (Azure#29005) * Fix spelling (Azure#29006) * Fix the description (Azure#29037) * Added suppression for LroExtension (Azure#29072) * rename mediaStreamingUpdateResult to mediaStreamingUpdate (Azure#29090) * [Call Automation] Create Connect interface (Azure#29075) * update swagger and add sample for Connect * update description * add description for call locator * update description for connectFailed event * rename ConnectCall to Connect in example * update description * fix style * adding operation context * revert renaming mediaStreamingUpdateResult * fix example * make change to re-trigger pipelines * add back the rename from base branch --------- Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com> --------- Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com> Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com> Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com> Co-authored-by: Paresh Arvind Patil <papati@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com> Co-authored-by: elavarasid <101957302+elavarasidc@users.noreply.github.com> Co-authored-by: James Deng (ACS) <jamesdeng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.