Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Custom Data Model injection feature #209

Merged
merged 22 commits into from
May 24, 2022
Merged

[Feature] Custom Data Model injection feature #209

merged 22 commits into from
May 24, 2022

Conversation

JoshuaLai
Copy link
Member

Purpose

Introducing the new data model injection for remote participants
Introduce new event handler design for remote participant joined

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

vhuseinova-msft and others added 21 commits May 2, 2022 08:42
@vhuseinova-msft
[Feature] Add an event for notifying when participants joined a call (#…
6408aa7 
…148)
@vhuseinova-msft
Merge branch 'develop/beta' of https://github.com/Azure/communication…
63ce875 
…-ui-library-ios into feature/customdatamodel

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI/CallComposite.swift
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/Manager/AvatarViewManager.swift
@vhuseinova-msft
[Feature] Add functionality for setting remote participant persona da…
57c02fe 
…ta (#154)
@vhuseinova-msft
Merge branch 'develop/beta' of https://github.com/Azure/communication…
8a9ced0 
…-ui-library-ios into feature/customdatamodel

# Conflicts:
#	AzureCommunicationUI/AzureCommunicationUI/Presentation/Manager/CompositeErrorManager.swift
@vhuseinova-msft
Merge branch 'develop/beta' of https://github.com/Azure/communication…
0caee9e 
…-ui-library-ios into feature/customdatamodel

# Conflicts:
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling.xcodeproj/project.pbxproj
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling/Presentation/Manager/RemoteParticipantsManager.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICallingTests/CallingSDKEventsHandlerMocking.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICallingTests/Manager/AvatarManagerTests.swift
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICallingTests/Manager/CompositeRemoteParticipantsManagerTests.swift
@vhuseinova-msft
Tests fix
a2dd7cc
@JoshuaLai
[Refactor] Update PersonaData argument name (#166)
628c408
@vhuseinova-msft
[Feature] Display remote participants persona data in the grid view (#…
4743c88 
…171)
@JoshuaLai
Merge branch 'develop/beta' of github.com:Azure/communication-ui-libr…
09caf07 
…ary-ios into feature/customdatamodel
@JoshuaLai
[Project] Resolve conflicts
a74f23a
@JoshuaLai
[Project] Resolving project conflicts
fcd37bc
@JoshuaLai
[Feature] Change how we set event handler (#174)
71e1b16
@JoshuaLai
[DependancyContainer] fixing run time crash for avatar manager
f5b32a2
@vhuseinova-msft
[Feature] Display participants view data in the participants list (#179)
6dea57e
@JoshuaLai
Merge branch 'develop/beta' of github.com:Azure/communication-ui-libr…
dab2ebe 
…ary-ios into feature/customdatamodel
@JoshuaLai
Merge branch 'develop/beta' of github.com:Azure/communication-ui-libr…
3d2167a 
…ary-ios into feature/customdatamodel
@vhuseinova-msft
Merge branch 'develop/beta' of https://github.com/Azure/communication…
2c90eca 
…-ui-library-ios into feature/customdatamodel

# Conflicts:
#	CHANGELOG.md
@vhuseinova-msft
[Feature] Error handling for participants view data (#205)
da84ee2
@JoshuaLai
[Project] Resolve conflicts in error manager
1c79190
@JoshuaLai
[Project] resolve project conflicts
ec46a8b
@JoshuaLai
[Changelog] updating change log
4566dc6
@JoshuaLai JoshuaLai requested review from a team as code owners May 24, 2022 17:43
@acs-ui-bot acs-ui-bot added the feature For new features intended for a future release label May 24, 2022
palatter
palatter approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! Just some minor comments.

@JoshuaLai JoshuaLai merged commit 048acb1 into develop/beta May 24, 2022
@JoshuaLai JoshuaLai deleted the feature/customdatamodel branch May 24, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatter palatter palatter approved these changes

@AmyL219 AmyL219 AmyL219 approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev was automatically assigned from Azure/acs-ui-ios-reviewer-2

@kevinyulu kevinyulu Awaiting requested review from kevinyulu kevinyulu was automatically assigned from Azure/acs-ui-ios-reviewer-3

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
feature For new features intended for a future release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshuaLai @palatter @AmyL219 @acs-ui-bot @vhuseinova-msft