Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retired services node #632

Merged
merged 4 commits into from
Mar 15, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 8, 2017

@lgalis
Copy link
Contributor Author

lgalis commented Mar 8, 2017

@miq-bot add_label enhancement, wip

@lgalis
Copy link
Contributor Author

lgalis commented Mar 8, 2017

@miq-bot add_label automation/ansible_tower

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible_tower

@lgalis lgalis force-pushed the add_retired_service_tree_node branch from e35903b to 6ef1b7d Compare March 8, 2017 22:20
@dclarizio dclarizio self-assigned this Mar 11, 2017
@lgalis lgalis force-pushed the add_retired_service_tree_node branch 10 times, most recently from a6799fd to 475c277 Compare March 15, 2017 12:59
@lgalis lgalis changed the title [WIP] Add retired services node Add retired services node Mar 15, 2017
@miq-bot miq-bot removed the wip label Mar 15, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 15, 2017

@miq-bot remove_label wip

@lgalis
Copy link
Contributor Author

lgalis commented Mar 15, 2017

@h-kataria this is ready for review

@lgalis lgalis force-pushed the add_retired_service_tree_node branch 3 times, most recently from 1bc9257 to 80f738e Compare March 15, 2017 20:53
@lgalis lgalis force-pushed the add_retired_service_tree_node branch from 80f738e to 595123e Compare March 15, 2017 21:13
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2017

Checked commits lgalis/manageiq-ui-classic@8dfb1ba~...595123e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
11 files checked, 17 offenses detected

app/helpers/application_helper/toolbar/service/lifecycle_mixin.rb

app/helpers/application_helper/toolbar/service/policy_mixin.rb

  • ❗ - Line 19, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 22, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/service/vmdb_mixin.rb

app/helpers/application_helper/toolbar_chooser.rb

spec/presenters/tree_builder_services_spec.rb

  • ❗ - Line 11, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

Copy link
Contributor

@h-kataria h-kataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dclarizio Tested in UI, LGTM.

@dclarizio
Copy link

Test failures are unrelated, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants