Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Display the same services in the tree as in the right-side list #14414

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 20, 2017

Display all services in the tree that are now displayed in the right-side list: services with no ancestry, regardless of the display field value,.
Links
upstream - ManageIQ/manageiq-ui-classic#632

https://bugzilla.redhat.com/show_bug.cgi?id=1431271

screenshot from 2017-03-20 14-50-38

@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot add_label ui, bug, wip

@lgalis lgalis changed the title [EUWE] Display the same services in the tree as in the right-side list [WIP][EUWE] Display the same services in the tree as in the right-side list Mar 20, 2017
@lgalis lgalis changed the title [WIP][EUWE] Display the same services in the tree as in the right-side list [EUWE] Display the same services in the tree as in the right-side list Mar 20, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot remove_label wip
@h-kataria - please review

@miq-bot miq-bot removed the wip label Mar 20, 2017
@miq-bot miq-bot changed the title [EUWE] Display the same services in the tree as in the right-side list [WIP] [EUWE] Display the same services in the tree as in the right-side list Mar 20, 2017
@miq-bot miq-bot added the wip label Mar 20, 2017
@lgalis lgalis changed the title [WIP] [EUWE] Display the same services in the tree as in the right-side list [EUWE] Display the same services in the tree as in the right-side list Mar 20, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Mar 20, 2017
@lgalis lgalis force-pushed the services_sync_tree_and_list_display branch from c91aa6a to 20ef367 Compare March 20, 2017 19:34
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Checked commit lgalis@20ef367 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

spec/presenters/tree_builder_services_spec.rb

Copy link
Contributor

@h-kataria h-kataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@simaishi simaishi merged commit 9982a90 into ManageIQ:euwe Mar 20, 2017
@simaishi simaishi added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 20, 2017
@himdel
Copy link
Contributor

himdel commented Mar 31, 2017

@lgalis is there a master PR somewhere please?

(trying to find out more about http://talk.manageiq.org/t/service-tree-doesnt-display-service-with-ancestry/2219 )

@lgalis
Copy link
Contributor Author

lgalis commented Mar 31, 2017

@himdel - this is the PR for master - ManageIQ/manageiq-ui-classic#632
However - for Euwe, the right side was displaying only services with no ancestry, while the tree was displaying services with the display not false - this PR brings them in sync, as requested in the BZ and discussed with @h-kataria and @dclarizio.

@lgalis lgalis deleted the services_sync_tree_and_list_display branch March 31, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants