Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [EUWE] Display the retired services in a separate tree node #14400

Closed
wants to merge 4 commits into from

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 20, 2017

@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot add_label ui, wip

@lgalis lgalis force-pushed the add_retired_services_node branch 2 times, most recently from a5c6904 to 2f1dc8b Compare March 20, 2017 14:25
@lgalis lgalis changed the title [WIP] [EUWE] Display the retired services in a separate list [EUWE] Display the retired services in a separate list Mar 20, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot remove_label wip
@h-kataria - please review

@miq-bot miq-bot changed the title [EUWE] Display the retired services in a separate list [WIP] [EUWE] Display the retired services in a separate list Mar 20, 2017
@miq-bot miq-bot added ui wip and removed wip labels Mar 20, 2017
@lgalis lgalis changed the title [WIP] [EUWE] Display the retired services in a separate list [EUWE] Display the retired services in a separate list Mar 20, 2017
@miq-bot miq-bot removed the wip label Mar 20, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Checked commits lgalis/manageiq@221af1c~...d6c1504 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
11 files checked, 15 offenses detected

app/helpers/application_helper/toolbar/service/lifecycle_mixin.rb

  • ❗ - Line 19, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 28, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 29, Col 10 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 30, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/service/policy_mixin.rb

  • ❗ - Line 19, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 22, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/service/vmdb_mixin.rb

  • ❗ - Line 19, Col 30 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 28, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 37, Col 31 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 40, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar_chooser.rb

app/presenters/tree_builder_services.rb

@lgalis lgalis changed the title [EUWE] Display the retired services in a separate list [WIP] [EUWE] Display the retired services in a separate list Mar 20, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 20, 2017

@miq-bot add_label wip - waiting for the decision regarding the new retired services node in the euwe branch

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

@lgalis Cannot apply the following label because they are not recognized: wip - waiting for the decision regarding the new retired services node in the euwe branch

@miq-bot miq-bot added the wip label Mar 20, 2017
@lgalis lgalis changed the title [WIP] [EUWE] Display the retired services in a separate list [WIP] [EUWE] Display the retired services in a separate tree node Mar 20, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

This pull request is not mergeable. Please rebase and repush.

@lgalis
Copy link
Contributor Author

lgalis commented Mar 21, 2017

Closing - will not include all these changes in Euwe - only the partial changes merged in #14414

@lgalis lgalis closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants