Add a flag to disable Xcode version check failure #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Xcode 10 and 11, many Xcode PRs to update bluepill have required simply updating the default SDK and Xcode version. Throughout most releases of Xcode 11.4, bluepill has worked without many major changes. At the speed that Apple is moving on Xcode releases, it's a lot of effort to bump these: PRs, branching, rebuilding, etc. This flag makes it a bit easier for us to test new versions of Xcode without having to create a build and PR for bluepill. For now, it's defaulted, but perhaps we should make it default to on and print a warning if it doesn't match. Additionally, we should consider dynamically pulling in the runtime version
ravimandala
previously approved these changes
Apr 22, 2020
ravimandala
force-pushed
the
jmarino_add_xcode_version_check_skipping
branch
from
603745f
to
838df7f
Compare
ravimandala
approved these changes
Apr 28, 2020
RainNapper
pushed a commit
to RainNapper/bluepill
that referenced
this pull request
May 8, 2020
…tion#436) * Add a flag to disable Xcode version check failure For Xcode 10 and 11, many Xcode PRs to update bluepill have required simply updating the default SDK and Xcode version. Throughout most releases of Xcode 11.4, bluepill has worked without a lot of major changes. At the speed that Apple is moving on Xcode releases, it's a lot of effort to bump these: PRs, branching, rebuilding, etc. This flag makes it a bit easier for us to test new versions of Xcode without having to create a build and PR for bluepill. For now, it's defaulted, but perhaps we should make it default to on and print a warning if it doesn't match. Additionally, we should consider dynamically pulling in the runtime version Co-authored-by: Ravi Mandala <rmandala@linkedin.com>
RainNapper
pushed a commit
to RainNapper/bluepill
that referenced
this pull request
May 8, 2020
…tion#436) * Add a flag to disable Xcode version check failure For Xcode 10 and 11, many Xcode PRs to update bluepill have required simply updating the default SDK and Xcode version. Throughout most releases of Xcode 11.4, bluepill has worked without a lot of major changes. At the speed that Apple is moving on Xcode releases, it's a lot of effort to bump these: PRs, branching, rebuilding, etc. This flag makes it a bit easier for us to test new versions of Xcode without having to create a build and PR for bluepill. For now, it's defaulted, but perhaps we should make it default to on and print a warning if it doesn't match. Additionally, we should consider dynamically pulling in the runtime version Co-authored-by: Ravi Mandala <rmandala@linkedin.com>
RainNapper
pushed a commit
to jerrymarino/bluepill
that referenced
this pull request
May 8, 2020
…tion#436) * Add a flag to disable Xcode version check failure For Xcode 10 and 11, many Xcode PRs to update bluepill have required simply updating the default SDK and Xcode version. Throughout most releases of Xcode 11.4, bluepill has worked without a lot of major changes. At the speed that Apple is moving on Xcode releases, it's a lot of effort to bump these: PRs, branching, rebuilding, etc. This flag makes it a bit easier for us to test new versions of Xcode without having to create a build and PR for bluepill. For now, it's defaulted, but perhaps we should make it default to on and print a warning if it doesn't match. Additionally, we should consider dynamically pulling in the runtime version Co-authored-by: Ravi Mandala <rmandala@linkedin.com>
AhmedEid
added a commit
to tinyspeck/bluepill
that referenced
this pull request
Nov 18, 2020
* master: Reference libXCTestBundleInject.dylib only if it exists (MobileNativeFoundation#460) Record video using simctl (MobileNativeFoundation#441) Xcode 12.0 support (MobileNativeFoundation#458) Retry app crash tests and consider then non-fatal if they pass (MobileNativeFoundation#456) Do not retry crashed tests (MobileNativeFoundation#443) Fixing minor issues and doing some minor refactoring/clean-up (MobileNativeFoundation#444) Xcode 11.5 support (MobileNativeFoundation#447) Xcode 11.4 support (MobileNativeFoundation#446) Add a flag to disable Xcode version check failure (MobileNativeFoundation#436) Support sidecar applications (MobileNativeFoundation#438) Added a few more tests to mock test failure scenarios and fixed a few final Exit Status issues (MobileNativeFoundation#430) make retry checks more resilient to prevent infinite retries (MobileNativeFoundation#432) Xcode 11.3 support (MobileNativeFoundation#426) Supporting tests and app hosts in subfolders (MobileNativeFoundation#419) # Conflicts: # bp/src/SimulatorHelper.m # bp/tests/SimulatorHelperTests.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Xcode 10 and 11, many PRs to update bluepill have required simply
updating the default SDK and Xcode version. Throughout most releases of Xcode
11, bluepill has worked without many major changes. At the speed that Apple
is moving on Xcode releases, it's a lot of effort to bump these: PRs,
branching, rebuilding, etc.
This flag makes it a bit easier for us to test new versions of Xcode
without having to create a build and PR for bluepill.
For now, it's defaulted, but perhaps we should make it default to on and print
a warning if it doesn't match. Additionally, we should consider dynamically
pulling in the runtime version