-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record video using simctl #441
Record video using simctl #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
ba8bbe8
to
87a3c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for contributing this feature.
Could we add a test case that actually records video for a test and checks that video was recorded? I think it could be wired in one of the tests that runs BPSampleApp
.
87a3c57
to
7d44d11
Compare
Added a test in the last push. |
5d5b5b3
to
d43a4bc
Compare
e48eaeb
to
bc4baa8
Compare
1a0eb3c
to
f1bc12d
Compare
f1bc12d
to
a17309f
Compare
a17309f
to
a33162d
Compare
Hi there, you may want to allow the user to change the codec option, h264 or hevc. Suggestion: Cool feature by the way. |
a33162d
to
a9cc178
Compare
da72c0b
to
c33de3c
Compare
c33de3c
to
996000b
Compare
Totally agree. bp is pretty heavy on the configs atm, mind adding this as a follow up PR? |
@RainNapper I like @kinwahlai's suggestion. The deleteOnTestPassed can either be a config, or the default behavior too. It would be great if you can create an issue to discuss and follow it up with a PR. Thanks for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Use the XCTest listener protocol to add hooks for `xcrun simctl io [sim-id] recordVideo`.
* master: Reference libXCTestBundleInject.dylib only if it exists (MobileNativeFoundation#460) Record video using simctl (MobileNativeFoundation#441) Xcode 12.0 support (MobileNativeFoundation#458) Retry app crash tests and consider then non-fatal if they pass (MobileNativeFoundation#456) Do not retry crashed tests (MobileNativeFoundation#443) Fixing minor issues and doing some minor refactoring/clean-up (MobileNativeFoundation#444) Xcode 11.5 support (MobileNativeFoundation#447) Xcode 11.4 support (MobileNativeFoundation#446) Add a flag to disable Xcode version check failure (MobileNativeFoundation#436) Support sidecar applications (MobileNativeFoundation#438) Added a few more tests to mock test failure scenarios and fixed a few final Exit Status issues (MobileNativeFoundation#430) make retry checks more resilient to prevent infinite retries (MobileNativeFoundation#432) Xcode 11.3 support (MobileNativeFoundation#426) Supporting tests and app hosts in subfolders (MobileNativeFoundation#419) # Conflicts: # bp/src/SimulatorHelper.m # bp/tests/SimulatorHelperTests.m
Use the XCTest listener protocol to add hooks for
xcrun simctl io [sim-id] recordVideo
.