Only reference libXCTestBundleInject.dylib if it exists #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob
previously approved these changes
Oct 7, 2020
RainNapper
force-pushed
the
mmark/bluepill/xc12-fix
branch
from
c8a2603
to
8eb9f4b
Compare
RainNapper
force-pushed
the
mmark/bluepill/xc12-fix
branch
from
8eb9f4b
to
6f2570f
Compare
ravimandala
pushed a commit
to ravimandala/bluepill
that referenced
this pull request
Oct 9, 2020
…Foundation#460) App will crash if this "optional" dylib does not exist in the host app bundle. Fixing it by making it truly optional.
AhmedEid
added a commit
to tinyspeck/bluepill
that referenced
this pull request
Nov 18, 2020
* master: Reference libXCTestBundleInject.dylib only if it exists (MobileNativeFoundation#460) Record video using simctl (MobileNativeFoundation#441) Xcode 12.0 support (MobileNativeFoundation#458) Retry app crash tests and consider then non-fatal if they pass (MobileNativeFoundation#456) Do not retry crashed tests (MobileNativeFoundation#443) Fixing minor issues and doing some minor refactoring/clean-up (MobileNativeFoundation#444) Xcode 11.5 support (MobileNativeFoundation#447) Xcode 11.4 support (MobileNativeFoundation#446) Add a flag to disable Xcode version check failure (MobileNativeFoundation#436) Support sidecar applications (MobileNativeFoundation#438) Added a few more tests to mock test failure scenarios and fixed a few final Exit Status issues (MobileNativeFoundation#430) make retry checks more resilient to prevent infinite retries (MobileNativeFoundation#432) Xcode 11.3 support (MobileNativeFoundation#426) Supporting tests and app hosts in subfolders (MobileNativeFoundation#419) # Conflicts: # bp/src/SimulatorHelper.m # bp/tests/SimulatorHelperTests.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App will crash if this dylib does not exist in the host app bundle. This dylib is not required for tests to run.