Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQL Toolbar #12067

Merged
merged 36 commits into from
Jan 7, 2021
Merged

feat: SQL Toolbar #12067

merged 36 commits into from
Jan 7, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Dec 15, 2020

SUMMARY

New sql toolbar added to sqlab

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Screen Shot 2021-01-06 at 5 30 26 PM

After

Screen Shot 2021-01-06 at 5 31 32 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #12067 (1da6815) into master (176f54d) will decrease coverage by 0.28%.
The diff coverage is 64.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12067      +/-   ##
==========================================
- Coverage   67.14%   66.86%   -0.29%     
==========================================
  Files        1002     1001       -1     
  Lines       49300    49988     +688     
  Branches     5010     5193     +183     
==========================================
+ Hits        33104    33426     +322     
- Misses      16071    16434     +363     
- Partials      125      128       +3     
Flag Coverage Δ
cypress 50.91% <51.21%> (-0.53%) ⬇️
javascript 61.02% <63.84%> (-0.18%) ⬇️
python 64.31% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/SqlLab/components/EstimateQueryCostButton.jsx 20.83% <0.00%> (ø)
...tend/src/SqlLab/components/ScheduleQueryButton.jsx 10.00% <ø> (ø)
...end/src/SqlLab/components/TemplateParamsEditor.jsx 13.88% <ø> (-75.00%) ⬇️
...perset-frontend/src/components/CopyToClipboard.jsx 57.14% <0.00%> (+4.96%) ⬆️
superset-frontend/src/components/Timer.tsx 95.83% <ø> (ø)
...perset-frontend/src/common/components/Dropdown.tsx 58.97% <23.80%> (-41.03%) ⬇️
...end/src/SqlLab/components/RunQueryActionButton.tsx 67.56% <62.06%> (-0.62%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 55.86% <65.47%> (+3.54%) ⬆️
...erset-frontend/src/SqlLab/components/SaveQuery.tsx 72.72% <80.00%> (-15.37%) ⬇️
...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx 92.68% <92.59%> (-0.87%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176f54d...1da6815. Read the comment docs.

hughhhh and others added 6 commits December 21, 2020 16:33
* save quite

* working func for ctas and cvas

* fixing errors

* fix type errors

* fix things

* fix

* styling for toolbar

* adjust styling

Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Victor Malai <malai9696@gmail.com>
Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com>
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Nikola Gigić <nik.gigic@gmail.com>
Co-authored-by: Jagadish <jagadishmts@gmail.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@hughhhh hughhhh marked this pull request as ready for review January 6, 2021 20:20
@hughhhh hughhhh changed the title Feat: SQL Toolbar feat: SQL Toolbar Jan 7, 2021
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @hughhhh and @eschutho for all the work!

@hughhhh hughhhh merged commit 9997abe into master Jan 7, 2021
@hughhhh hughhhh deleted the feat-sql-toolbar branch January 7, 2021 22:04
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants