-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(composition): composition rewrite #2148
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of the file, not the current working directory of Rover (#2119) As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself. I've added a unit test for this and run my own tests and it all seems to work ok. In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
<!-- First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo! Here are some important details to follow: * ⏰ Your time is important To save your precious time, if the contribution you are making will take more than an hour, please make sure it has been discussed in an issue first. This is especially true for feature requests! * 💡 Features Feature requests can be created and discussed within a GitHub Issue. Be sure to search for existing feature requests (and related issues!) prior to opening a new request. If an existing issue covers the need, please upvote that issue by using the 👍 emote, rather than opening a new issue. * 🕷 Bug fixes These can be created and discussed in this repository. When fixing a bug, please _try_ to add a test which verifies the fix. If you cannot, you should still submit the PR but we may still ask you (and help you!) to create a test. * 📖 Contribution guidelines Follow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md when submitting a pull request. Make sure existing tests still pass, and add tests for all new behavior. * ✏️ Explain your pull request Describe the big picture of your changes here to communicate to what your pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues! We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment. --> --------- Co-authored-by: Aaron <aaronarinder@gmail.com> Co-authored-by: Dan <danbond@protonmail.com>
aaronArinder
force-pushed
the
composition-integration
branch
from
September 18, 2024 12:45
1cb44db
to
1c14f51
Compare
aaronArinder
changed the title
feat(composition): --watch for events
feat(composition): events!
Sep 19, 2024
dotdat
changed the title
feat(composition): events!
feat(composition): composition rewrite
Sep 19, 2024
Co-authored-by: Brian George <brian@apollographql.com>
Cherry pick changes from 01695b4 Co-authored-by: Dylan Anthony <dylan@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.