Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composition): composition rewrite #2148

Closed
wants to merge 21 commits into from

Commits on Sep 18, 2024

  1. ROVER-135 Make paths in supergraph.yaml resolve relative to the locat…

    …ion of the file, not the current working directory of Rover (#2119)
    
    As per the title, to support integration with the Language Server we
    need to remove a 'quirk' of Rover whereby if you specify a file in the
    supergraph.yaml with a relative path, that path is resolved relative to
    the location that rover is running in at the time. This doesn't work in
    that context so instead we are changing it to resolve relative to the
    location of the supergraph.yaml file itself.
    
    I've added a unit test for this and run my own tests and it all seems to
    work ok.
    
    In addition I've fixed a test that has been broken for a long time, a
    more detailed write up on this test will follow
    
    Successful smoke test run:
    https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
    jonathanrainer authored and aaronArinder committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    faa8d67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd9551d View commit details
    Browse the repository at this point in the history
  3. Dotdat/composition handler runner (#2144)

    <!--
    First, 🌠 thank you 🌠 for taking the time to consider a contribution to
    Apollo!
    
    Here are some important details to follow:
    
    * ⏰ Your time is important
    To save your precious time, if the contribution you are making will
    take more than an hour, please make sure it has been discussed in an
            issue first. This is especially true for feature requests!
    
    * 💡 Features
    Feature requests can be created and discussed within a GitHub Issue.
    Be sure to search for existing feature requests (and related issues!)
    prior to opening a new request. If an existing issue covers the need,
    please upvote that issue by using the 👍 emote, rather than opening a
            new issue.
    
    * 🕷 Bug fixes
    These can be created and discussed in this repository. When fixing a
    bug,
    please _try_ to add a test which verifies the fix. If you cannot, you
    should
    still submit the PR but we may still ask you (and help you!) to create a
    test.
    
    * 📖 Contribution guidelines
    Follow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md
    when submitting a pull request. Make sure existing tests still pass, and
    add
            tests for all new behavior.
    
    * ✏️ Explain your pull request
    Describe the big picture of your changes here to communicate to what
            your pull request is meant to accomplish. Provide 🔗 links 🔗 to
            associated issues!
    
    We hope you will find this to be a positive experience! Open source
    contribution can be intimidating and we hope to alleviate that pain as
    much
    as possible. Without following these guidelines, you may be missing
    context
    that can help you succeed with your contribution, which is why we
    encourage
    discussion first. Ultimately, there is no guarantee that we will be able
    to
    merge your pull-request, but by following these guidelines we can try to
    avoid disappointment.
    
    -->
    
    ---------
    
    Co-authored-by: Aaron <aaronarinder@gmail.com>
    Co-authored-by: Dan <danbond@protonmail.com>
    3 people committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8997ebe View commit details
    Browse the repository at this point in the history
  4. Dotdat/supergraph watcher (#2145)

    dotdat authored and aaronArinder committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c7bdeee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e6685b0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1c14f51 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eab085b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c94d8ee View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d52e3c5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    61b41d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix cargo fmt errors

    loshz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5707102 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebde5e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    187bdf5 View commit details
    Browse the repository at this point in the history
  4. fix(supergraph config resolution): write to tempfile (#2158)

    Co-authored-by: Brian George <brian@apollographql.com>
    aaronArinder and dotdat committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0c16345 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f89be47 View commit details
    Browse the repository at this point in the history
  6. apollo-federation-types 0.14.1 (#2161)

    Cherry pick changes from
    01695b4
    
    Co-authored-by: Dylan Anthony <dylan@apollographql.com>
    loshz and dylan-apollo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e114cd6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    922214b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    90d4a74 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ffbc1b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    7f7577d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a34a3cb View commit details
    Browse the repository at this point in the history