Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor sortableTable with Aphrodite #10263

Closed
luixxiul opened this issue Aug 3, 2017 · 0 comments
Closed

Refactor sortableTable with Aphrodite #10263

luixxiul opened this issue Aug 3, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 3, 2017

Test plan

For 0.21.x
#10265 (comment)
#10454 (comment)


Describe the issue you encountered: Refactor sortableTable with Aphrodite.

This task will be conducted along with #9032, replacing table with grid.

@luixxiul luixxiul self-assigned this Aug 3, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
Addresses brave#10263

Auditors:

Test Plan:
1. Open about:preferences#search
2. Make sure the custom width is applied to the table
3. Open about:preferences#sync
4. Make sure the custom width is applied to the table
5. Open about:preferences#extensions
6. Make sure '-webkit-fill-available' is applied to the table
@luixxiul luixxiul removed their assignment Nov 8, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
Addresses #10263
Addresses #10788
Closes #10356

- Polish action icons
- Polish verified icon placement
- Remove alignRight from the sites column (it should be aligned to the left as default)
- Align the include switches to the center
- Align the action buttons to the center

Test Plan:
1. Visit https://www.youtube.com/user/latenight
2. Open about:preferences#payments
3. Make sure the channel title is aligned to the left
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants