Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix the wrong BEM naming on ledgerTable.js #10788

Closed
luixxiul opened this issue Sep 5, 2017 · 0 comments
Closed

Fix the wrong BEM naming on ledgerTable.js #10788

luixxiul opened this issue Sep 5, 2017 · 0 comments
Labels
feature/about-pages PR/pending-review QA/test-plan-specified release-notes/exclude wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 5, 2017 •
edited
Loading

Test Plan

#10789 (comment)

Describe the issue you encountered: Update ledgerTable to the modified BEM style.
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. labels Sep 5, 2017
@luixxiul luixxiul self-assigned this Sep 5, 2017
@luixxiul luixxiul mentioned this issue Sep 5, 2017
Merged
8 tasks
@luixxiul luixxiul changed the title Update ledgerTable to the modified BEM style Fix the wrong BEM naming on ledgerTable.js Nov 18, 2017
@luixxiul luixxiul removed the polish Nice to have — usually related to front-end/visual tasks. label Nov 18, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
@cezaraugusto
Normalize the tables on about:preferences
5d1919f 
Addresses #10263
Addresses #10788
Closes #10356

- Polish action icons
- Polish verified icon placement
- Remove alignRight from the sites column (it should be aligned to the left as default)
- Align the include switches to the center
- Align the action buttons to the center

Test Plan:
1. Visit https://www.youtube.com/user/latenight
2. Open about:preferences#payments
3. Make sure the channel title is aligned to the left
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/about-pages PR/pending-review QA/test-plan-specified release-notes/exclude wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luixxiul @bsclifton