Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix the wrong spacing around the per cent number on ledger panel #10356

Closed
luixxiul opened this issue Aug 9, 2017 · 2 comments · Fixed by #10789
Closed

Fix the wrong spacing around the per cent number on ledger panel #10356

luixxiul opened this issue Aug 9, 2017 · 2 comments · Fixed by #10789
Assignees
@luixxiul
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2017 •
edited
Loading

Describe the issue you encountered: Polish pinnedInput.js

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Run npm run add-simulated-synopsis-visits 100
    2. Open about:preferences#payments
    3. Pin some sites

  • Actual result:
    screenshot 2017-08-09 18 48 31

  • Expected result: the padding and margin around the input area should be normalized.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul self-assigned this Aug 9, 2017
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Aug 9, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 9, 2017
@luixxiul luixxiul mentioned this issue Aug 9, 2017
Closed
8 tasks
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 10, 2017 •
edited
Loading

note: the styles such as padding like https://github.com/luixxiul/browser-laptop/commit/777c2787699ea03b949b38d6612000fd6b763cdf#diff-e168dd994d1e4de3f340af83899a20f5R375 will be normalized later after #10265 is merged. The styles are scattered everywhere, not only less files which will be converted later but files which have already been converted eg ledgerTable.js, which is why some styles are just redundant, creating table layout inconsistency. cc: @cezaraugusto, related: #9032

This was referenced Sep 5, 2017
Closed
Merged
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Oct 31, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@luixxiul luixxiul changed the title Polish pinnedInput.js Fix the wrong spacing around the per cent number on ledger panel Nov 18, 2017
@luixxiul luixxiul removed polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Nov 18, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
@cezaraugusto
Normalize the tables on about:preferences
5d1919f 
Addresses #10263
Addresses #10788
Closes #10356

- Polish action icons
- Polish verified icon placement
- Remove alignRight from the sites column (it should be aligned to the left as default)
- Align the include switches to the center
- Align the action buttons to the center

Test Plan:
1. Visit https://www.youtube.com/user/latenight
2. Open about:preferences#payments
3. Make sure the channel title is aligned to the left
@luixxiul luixxiul modified the milestones: Prioritized Backlog, 0.22.x (Nightly Channel) Nov 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

This was referenced Jun 19, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Normalize the sortableTable on about:preferences
6 participants
@bbondy @alexwykoff @luixxiul @srirambv @LaurenWags @btlechowski